From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756306AbcC2JNF (ORCPT ); Tue, 29 Mar 2016 05:13:05 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:32928 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751569AbcC2JNC (ORCPT ); Tue, 29 Mar 2016 05:13:02 -0400 Date: Tue, 29 Mar 2016 10:12:58 +0100 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, maxime.coquelin@st.com, patrice.chotard@st.com, srinivas.kandagatla@gmail.com, devicetree@vger.kernel.org Subject: Re: [PATCH 4/4] ARM: STi: DT: STiH407: Add DT node for eeprom Message-ID: <20160329091258.GC8659@x1> References: <1458920188-29612-1-git-send-email-peter.griffin@linaro.org> <1458920188-29612-5-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1458920188-29612-5-git-send-email-peter.griffin@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org More information is required in the commit message. What do we use the EEPROM for? What information is contained within? What stops working if we don't support it? What starts working if we do? > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stihxxx-b2120.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi > index 133375b..0d7c6dd 100644 > --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi > +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi > @@ -58,6 +58,15 @@ > > i2c@9845000 { > status = "okay"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + eeprom@50 { > + compatible = "at,24c256"; > + pagesize = <64>; > + reg = <0x50>; > + }; > }; > > i2c@9540000 { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog