public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging: vt6655: defined some arrays as const arrays since they are not changed anywhere in code
@ 2016-03-27 12:09 Claudiu Beznea
  2016-03-29 21:38 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Claudiu Beznea @ 2016-03-27 12:09 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel, Claudiu Beznea

This patch defines byVT3253B0_AGC4_RFMD2959[], byVT3253B0_AIROHA2230[],
byVT3253B0_UW2451[] and byVT3253B0_AGC[] arrays as const arrays
since they are not change anywhere in code. After this change
some lines broke the 80 characters per line rule. To fix this,
some changed lines were splited on two.

Signed-off-by: Claudiu Beznea <claudiu.beznea@gmail.com>
---
 drivers/staging/vt6655/baseband.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
index 1e6c0c4..ff43393 100644
--- a/drivers/staging/vt6655/baseband.c
+++ b/drivers/staging/vt6655/baseband.c
@@ -777,7 +777,8 @@ static unsigned char byVT3253B0_RFMD[CB_VT3253B0_INIT_FOR_RFMD][2] = {
 
 #define CB_VT3253B0_AGC_FOR_RFMD2959 195
 /* For RFMD2959 */
-static unsigned char byVT3253B0_AGC4_RFMD2959[CB_VT3253B0_AGC_FOR_RFMD2959][2] = {
+static const
+unsigned char byVT3253B0_AGC4_RFMD2959[CB_VT3253B0_AGC_FOR_RFMD2959][2] = {
 	{0xF0, 0x00},
 	{0xF1, 0x3E},
 	{0xF0, 0x80},
@@ -977,7 +978,8 @@ static unsigned char byVT3253B0_AGC4_RFMD2959[CB_VT3253B0_AGC_FOR_RFMD2959][2] =
 
 #define CB_VT3253B0_INIT_FOR_AIROHA2230 256
 /* For AIROHA */
-static unsigned char byVT3253B0_AIROHA2230[CB_VT3253B0_INIT_FOR_AIROHA2230][2] = {
+static const
+unsigned char byVT3253B0_AIROHA2230[CB_VT3253B0_INIT_FOR_AIROHA2230][2] = {
 	{0x00, 0x31},
 	{0x01, 0x00},
 	{0x02, 0x00},
@@ -1238,7 +1240,7 @@ static unsigned char byVT3253B0_AIROHA2230[CB_VT3253B0_INIT_FOR_AIROHA2230][2] =
 
 #define CB_VT3253B0_INIT_FOR_UW2451 256
 /* For UW2451 */
-static unsigned char byVT3253B0_UW2451[CB_VT3253B0_INIT_FOR_UW2451][2] = {
+static const unsigned char byVT3253B0_UW2451[CB_VT3253B0_INIT_FOR_UW2451][2] = {
 	{0x00, 0x31},
 	{0x01, 0x00},
 	{0x02, 0x00},
@@ -1499,7 +1501,7 @@ static unsigned char byVT3253B0_UW2451[CB_VT3253B0_INIT_FOR_UW2451][2] = {
 
 #define CB_VT3253B0_AGC 193
 /* For AIROHA */
-static unsigned char byVT3253B0_AGC[CB_VT3253B0_AGC][2] = {
+static const unsigned char byVT3253B0_AGC[CB_VT3253B0_AGC][2] = {
 	{0xF0, 0x00},
 	{0xF1, 0x00},
 	{0xF0, 0x80},
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Staging: vt6655: defined some arrays as const arrays since they are not changed anywhere in code
  2016-03-27 12:09 [PATCH] Staging: vt6655: defined some arrays as const arrays since they are not changed anywhere in code Claudiu Beznea
@ 2016-03-29 21:38 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-03-29 21:38 UTC (permalink / raw)
  To: Claudiu Beznea; +Cc: devel, linux-kernel

On Sun, Mar 27, 2016 at 03:09:35PM +0300, Claudiu Beznea wrote:
> This patch defines byVT3253B0_AGC4_RFMD2959[], byVT3253B0_AIROHA2230[],
> byVT3253B0_UW2451[] and byVT3253B0_AGC[] arrays as const arrays
> since they are not change anywhere in code. After this change
> some lines broke the 80 characters per line rule. To fix this,
> some changed lines were splited on two.
> 
> Signed-off-by: Claudiu Beznea <claudiu.beznea@gmail.com>
> ---
>  drivers/staging/vt6655/baseband.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)

This does not apply to my staging-next branch at all :(

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-03-29 21:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-27 12:09 [PATCH] Staging: vt6655: defined some arrays as const arrays since they are not changed anywhere in code Claudiu Beznea
2016-03-29 21:38 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox