From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ming Li <mingli199x@qq.com>
Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>,
Aybuke Ozdemir <aybuke.147@gmail.com>,
Burcin Akalin <brcnakalin@gmail.com>,
Anton Tatuev <tatuev.a.a@yandex.ru>,
Deepa Dinamani <deepa.kernel@gmail.com>,
devel <devel@driverdev.osuosl.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Skein:move macros into appropriate header files
Date: Tue, 29 Mar 2016 18:00:03 -0700 [thread overview]
Message-ID: <20160330010003.GA19630@kroah.com> (raw)
In-Reply-To: <tencent_4DB13CB4107C4648365A2D5A@qq.com>
On Wed, Mar 30, 2016 at 08:51:42AM +0800, Ming Li wrote:
> hi, i move macros into header files.
>
>
> regards,
>
>
> Signed-off-by: Ming Li <mingli199x@qq.com>
That's a very strange changelog comment, can you please expand on what
you are doing this for?
You need to explain _why_ you are doing something, not what you are
doing.
thanks,
greg k-h
next parent reply other threads:[~2016-03-30 1:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_4DB13CB4107C4648365A2D5A@qq.com>
2016-03-30 1:00 ` Greg Kroah-Hartman [this message]
[not found] <tencent_6A323943144FE411111B9878@qq.com>
2016-05-01 16:24 ` [PATCH] Skein:move macros into appropriate header files Greg Kroah-Hartman
[not found] <tencent_67DBCF475EFD4D78791F8738@qq.com>
2016-03-21 19:15 ` [patch] " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330010003.GA19630@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amitoj1606@gmail.com \
--cc=aybuke.147@gmail.com \
--cc=brcnakalin@gmail.com \
--cc=deepa.kernel@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingli199x@qq.com \
--cc=tatuev.a.a@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox