From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753206AbcC3BAG (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Mar 2016 21:00:06 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:37702 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752100AbcC3BAF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Mar 2016 21:00:05 -0400
Date: Tue, 29 Mar 2016 18:00:03 -0700
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ming Li <mingli199x@qq.com>
Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>,
        Aybuke Ozdemir <aybuke.147@gmail.com>,
        Burcin Akalin <brcnakalin@gmail.com>,
        Anton Tatuev <tatuev.a.a@yandex.ru>,
        Deepa Dinamani <deepa.kernel@gmail.com>,
        devel <devel@driverdev.osuosl.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Skein:move macros into appropriate header files
Message-ID: <20160330010003.GA19630@kroah.com>
References: <tencent_4DB13CB4107C4648365A2D5A@qq.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tencent_4DB13CB4107C4648365A2D5A@qq.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 30, 2016 at 08:51:42AM +0800, Ming Li wrote:
> hi, i move macros into header files.  
> 
> 
> regards,
> 
> 
> Signed-off-by: Ming Li <mingli199x@qq.com>

That's a very strange changelog comment, can you please expand on what
you are doing this for?

You need to explain _why_ you are doing something, not what you are
doing.

thanks,

greg k-h