* Re: [PATCH] Skein:move macros into appropriate header files [not found] <tencent_4DB13CB4107C4648365A2D5A@qq.com> @ 2016-03-30 1:00 ` Greg Kroah-Hartman 0 siblings, 0 replies; 3+ messages in thread From: Greg Kroah-Hartman @ 2016-03-30 1:00 UTC (permalink / raw) To: Ming Li Cc: Amitoj Kaur Chawla, Aybuke Ozdemir, Burcin Akalin, Anton Tatuev, Deepa Dinamani, devel, linux-kernel On Wed, Mar 30, 2016 at 08:51:42AM +0800, Ming Li wrote: > hi, i move macros into header files. > > > regards, > > > Signed-off-by: Ming Li <mingli199x@qq.com> That's a very strange changelog comment, can you please expand on what you are doing this for? You need to explain _why_ you are doing something, not what you are doing. thanks, greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <tencent_6A323943144FE411111B9878@qq.com>]
* Re: [PATCH] Skein:move macros into appropriate header files [not found] <tencent_6A323943144FE411111B9878@qq.com> @ 2016-05-01 16:24 ` Greg Kroah-Hartman 0 siblings, 0 replies; 3+ messages in thread From: Greg Kroah-Hartman @ 2016-05-01 16:24 UTC (permalink / raw) To: Ming Li Cc: Amitoj Kaur Chawla, Aybuke Ozdemir, Burcin Akalin, Anton Tatuev, Deepa Dinamani, devel, linux-kernel On Tue, Mar 22, 2016 at 08:17:07PM +0800, Ming Li wrote: > hi, i move macros into appropriate header files. Why? What other code needs these macros to require them being moved to a .h file? confused, greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <tencent_67DBCF475EFD4D78791F8738@qq.com>]
* Re: [patch] Skein:move macros into appropriate header files [not found] <tencent_67DBCF475EFD4D78791F8738@qq.com> @ 2016-03-21 19:15 ` Greg Kroah-Hartman 0 siblings, 0 replies; 3+ messages in thread From: Greg Kroah-Hartman @ 2016-03-21 19:15 UTC (permalink / raw) To: Ming Li Cc: Aybuke Ozdemir, Deepa Dinamani, Amitoj Kaur Chawla, Burcin Akalin, Anton Tatuev, devel, linux-kernel On Mon, Mar 21, 2016 at 06:44:04PM +0800, Ming Li wrote: > hi, in drivers/staging/skein/, i move macros into appropriate header files. > > > Regards, > > > Signed-off-by: Ming Li Please use scripts/checkpatch.pl to find the errors in your patch before sending. Also, don't send html email, it gets rejected by the mailing lists and it corrupts the patch. thanks, greg k-h ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-01 16:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <tencent_4DB13CB4107C4648365A2D5A@qq.com>
2016-03-30 1:00 ` [PATCH] Skein:move macros into appropriate header files Greg Kroah-Hartman
[not found] <tencent_6A323943144FE411111B9878@qq.com>
2016-05-01 16:24 ` Greg Kroah-Hartman
[not found] <tencent_67DBCF475EFD4D78791F8738@qq.com>
2016-03-21 19:15 ` [patch] " Greg Kroah-Hartman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox