From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Juri Lelli <juri.lelli@arm.com>,
Wanpeng Li <wanpeng.li@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>, Kirill V Tkhai <tkhai@yandex.ru>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] sched/deadline: do not try to push tasks if pinned task switches to dl
Date: Wed, 30 Mar 2016 08:44:55 +0200 [thread overview]
Message-ID: <20160330064455.GQ3408@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20160329184722.0d54b946@gandalf.local.home>
On Tue, Mar 29, 2016 at 06:47:22PM -0400, Steven Rostedt wrote:
> I'm looking at some old changes for sched-deadline, and I stumbled
> across this. As I'm working on sched deadline tests, I've discovered
> that they can't have cpu affinity. They are limited to their sched
> domains. That is, sched deadline tasks have whatever affinity that the
> domain they happen to be in has.
>
> Is there a condition where rq != task_rq(p) and p->nr_cpus_allowed > 1
> isn't true?
When holding rq->lock, no. I suppose the patch was just to mirror rt and
someone 'forgot' about the extra constraints on dl tasks.
next prev parent reply other threads:[~2016-03-30 6:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 0:36 [PATCH v3] sched/deadline: do not try to push tasks if pinned task switches to dl Wanpeng Li
2014-10-22 9:33 ` Juri Lelli
2016-03-29 22:47 ` Steven Rostedt
2016-03-30 6:44 ` Peter Zijlstra [this message]
2016-03-30 7:59 ` Wanpeng Li
2014-10-28 11:06 ` [tip:sched/core] sched/deadline: Do " tip-bot for Wanpeng Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330064455.GQ3408@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=tkhai@yandex.ru \
--cc=wanpeng.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox