From: Christoph Hellwig <hch@infradead.org>
To: Shaohua Li <shli@fb.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
axboe@fb.com, Kernel-team@fb.com, "4.2+" <stable@vger.kernel.org>,
Ming Lei <ming.lei@canonical.com>
Subject: Re: [PATCH] block: don't make BLK_DEF_MAX_SECTORS too big
Date: Tue, 29 Mar 2016 23:51:51 -0700 [thread overview]
Message-ID: <20160330065151.GA29666@infradead.org> (raw)
In-Reply-To: <20160329220053.GA1716708@devbig084.prn1.facebook.com>
On Tue, Mar 29, 2016 at 03:01:10PM -0700, Shaohua Li wrote:
> The problem is bcache allocates a big bio (with bio_alloc). The bio is
> split with blk_queue_split, but it isn't split to small size because
> queue limit. the bio is cloned later in md, which uses bio_alloc_bioset.
> bio_alloc_bioset itself can't allocate big size bio.
bcache should be fixed to not allocate larger than allowed bios then.
And handling too large arguments to bio_alloc_bioset is still useful to
avoid the checks in the callers and make it robust.
next prev parent reply other threads:[~2016-03-30 6:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 16:42 [PATCH] block: don't make BLK_DEF_MAX_SECTORS too big Shaohua Li
2016-03-29 21:18 ` Christoph Hellwig
2016-03-29 22:01 ` Shaohua Li
2016-03-30 6:51 ` Christoph Hellwig [this message]
2016-03-30 16:50 ` Shaohua Li
2016-03-30 17:40 ` Christoph Hellwig
2016-03-31 0:52 ` Kent Overstreet
2016-03-30 1:39 ` Ming Lei
2016-03-30 2:27 ` Shaohua Li
2016-03-30 12:13 ` Ming Lei
2016-03-30 17:07 ` Shaohua Li
2016-03-31 0:49 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330065151.GA29666@infradead.org \
--to=hch@infradead.org \
--cc=Kernel-team@fb.com \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=shli@fb.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox