From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754739AbcC3G4t (ORCPT ); Wed, 30 Mar 2016 02:56:49 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:48132 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752997AbcC3G4s (ORCPT ); Wed, 30 Mar 2016 02:56:48 -0400 Date: Tue, 29 Mar 2016 23:56:46 -0700 From: Christoph Hellwig To: Vishal Verma Cc: Christoph Hellwig , Vishal Verma , linux-block@vger.kernel.org, Jan Kara , linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, Jens Axboe , linux-mm@kvack.org, Matthew Wilcox , linux-fsdevel@vger.kernel.org, Andrew Morton , linux-ext4@vger.kernel.org, Al Viro Subject: Re: [PATCH v2 5/5] dax: handle media errors in dax_do_io Message-ID: <20160330065646.GA13123@infradead.org> References: <1459303190-20072-1-git-send-email-vishal.l.verma@intel.com> <1459303190-20072-6-git-send-email-vishal.l.verma@intel.com> <20160330063415.GA2132@infradead.org> <1459320877.4102.3.camel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459320877.4102.3.camel@kernel.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 30, 2016 at 12:54:37AM -0600, Vishal Verma wrote: > On Tue, 2016-03-29 at 23:34 -0700, Christoph Hellwig wrote: > > Hi Vishal, > > > > still NAK to calling the direct I/O code directly from the dax code. > > Hm, I thought this was what you meant -- do the fallback/retry attempts > at the callers of dax_do_io instead of the new dax wrapper function.. > Did I misunderstand you? Sorry, it is. I misread fs/block_dev.c as fs/dax.c before my first coffee this morning. I'll properly review the series in the afternoon..