From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932759AbcC3ILo (ORCPT ); Wed, 30 Mar 2016 04:11:44 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:35422 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753526AbcC3IKk (ORCPT ); Wed, 30 Mar 2016 04:10:40 -0400 Date: Wed, 30 Mar 2016 09:10:36 +0100 From: Lee Jones To: Krzysztof Kozlowski Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org Subject: Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM Message-ID: <20160330081036.GC3323@x1> References: <1459298921-20410-1-git-send-email-k.kozlowski@samsung.com> <20160330080856.GB3323@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160330080856.GB3323@x1> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Mar 2016, Lee Jones wrote: > On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote: > > > The devres.o gets linked if HAS_IOMEM is present so on ARCH=um > > allyesconfig (COMPILE_TEST) failed with: > > > > drivers/built-in.o: In function `omap_control_phy_probe': > > phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource' > > drivers/built-in.o: In function `cygnus_pcie_phy_probe': > > phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource' > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > drivers/phy/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > Holding off on this until the discussion reaches some kind of > consensus. FYI: https://lkml.org/lkml/2016/3/29/716 > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > > index 26566db09de0..879ac798f6f7 100644 > > --- a/drivers/phy/Kconfig > > +++ b/drivers/phy/Kconfig > > @@ -128,6 +128,7 @@ config PHY_RCAR_GEN3_USB2 > > config OMAP_CONTROL_PHY > > tristate "OMAP CONTROL PHY Driver" > > depends on ARCH_OMAP2PLUS || COMPILE_TEST > > + depends on HAS_IOMEM > > help > > Enable this to add support for the PHY part present in the control > > module. This driver has API to power on the USB2 PHY and to write to > > @@ -415,6 +416,7 @@ config PHY_BRCMSTB_SATA > > config PHY_CYGNUS_PCIE > > tristate "Broadcom Cygnus PCIe PHY driver" > > depends on OF && (ARCH_BCM_CYGNUS || COMPILE_TEST) > > + depends on HAS_IOMEM > > select GENERIC_PHY > > default ARCH_BCM_CYGNUS > > help > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog