* [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM
@ 2016-03-30 0:48 Krzysztof Kozlowski
2016-03-30 8:08 ` Lee Jones
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2016-03-30 0:48 UTC (permalink / raw)
To: Kishon Vijay Abraham I, linux-kernel; +Cc: Lee Jones, Krzysztof Kozlowski
The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
allyesconfig (COMPILE_TEST) failed with:
drivers/built-in.o: In function `omap_control_phy_probe':
phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource'
drivers/built-in.o: In function `cygnus_pcie_phy_probe':
phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource'
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/phy/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 26566db09de0..879ac798f6f7 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -128,6 +128,7 @@ config PHY_RCAR_GEN3_USB2
config OMAP_CONTROL_PHY
tristate "OMAP CONTROL PHY Driver"
depends on ARCH_OMAP2PLUS || COMPILE_TEST
+ depends on HAS_IOMEM
help
Enable this to add support for the PHY part present in the control
module. This driver has API to power on the USB2 PHY and to write to
@@ -415,6 +416,7 @@ config PHY_BRCMSTB_SATA
config PHY_CYGNUS_PCIE
tristate "Broadcom Cygnus PCIe PHY driver"
depends on OF && (ARCH_BCM_CYGNUS || COMPILE_TEST)
+ depends on HAS_IOMEM
select GENERIC_PHY
default ARCH_BCM_CYGNUS
help
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM
2016-03-30 0:48 [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM Krzysztof Kozlowski
@ 2016-03-30 8:08 ` Lee Jones
2016-03-30 8:10 ` Lee Jones
0 siblings, 1 reply; 5+ messages in thread
From: Lee Jones @ 2016-03-30 8:08 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Kishon Vijay Abraham I, linux-kernel
On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote:
> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
> allyesconfig (COMPILE_TEST) failed with:
>
> drivers/built-in.o: In function `omap_control_phy_probe':
> phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource'
> drivers/built-in.o: In function `cygnus_pcie_phy_probe':
> phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource'
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/phy/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
Holding off on this until the discussion reaches some kind of
consensus.
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 26566db09de0..879ac798f6f7 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -128,6 +128,7 @@ config PHY_RCAR_GEN3_USB2
> config OMAP_CONTROL_PHY
> tristate "OMAP CONTROL PHY Driver"
> depends on ARCH_OMAP2PLUS || COMPILE_TEST
> + depends on HAS_IOMEM
> help
> Enable this to add support for the PHY part present in the control
> module. This driver has API to power on the USB2 PHY and to write to
> @@ -415,6 +416,7 @@ config PHY_BRCMSTB_SATA
> config PHY_CYGNUS_PCIE
> tristate "Broadcom Cygnus PCIe PHY driver"
> depends on OF && (ARCH_BCM_CYGNUS || COMPILE_TEST)
> + depends on HAS_IOMEM
> select GENERIC_PHY
> default ARCH_BCM_CYGNUS
> help
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM
2016-03-30 8:08 ` Lee Jones
@ 2016-03-30 8:10 ` Lee Jones
2016-03-30 8:23 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Lee Jones @ 2016-03-30 8:10 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Kishon Vijay Abraham I, linux-kernel
On Wed, 30 Mar 2016, Lee Jones wrote:
> On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote:
>
> > The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
> > allyesconfig (COMPILE_TEST) failed with:
> >
> > drivers/built-in.o: In function `omap_control_phy_probe':
> > phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource'
> > drivers/built-in.o: In function `cygnus_pcie_phy_probe':
> > phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource'
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> > drivers/phy/Kconfig | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Holding off on this until the discussion reaches some kind of
> consensus.
FYI: https://lkml.org/lkml/2016/3/29/716
> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> > index 26566db09de0..879ac798f6f7 100644
> > --- a/drivers/phy/Kconfig
> > +++ b/drivers/phy/Kconfig
> > @@ -128,6 +128,7 @@ config PHY_RCAR_GEN3_USB2
> > config OMAP_CONTROL_PHY
> > tristate "OMAP CONTROL PHY Driver"
> > depends on ARCH_OMAP2PLUS || COMPILE_TEST
> > + depends on HAS_IOMEM
> > help
> > Enable this to add support for the PHY part present in the control
> > module. This driver has API to power on the USB2 PHY and to write to
> > @@ -415,6 +416,7 @@ config PHY_BRCMSTB_SATA
> > config PHY_CYGNUS_PCIE
> > tristate "Broadcom Cygnus PCIe PHY driver"
> > depends on OF && (ARCH_BCM_CYGNUS || COMPILE_TEST)
> > + depends on HAS_IOMEM
> > select GENERIC_PHY
> > default ARCH_BCM_CYGNUS
> > help
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM
2016-03-30 8:10 ` Lee Jones
@ 2016-03-30 8:23 ` Krzysztof Kozlowski
2016-03-30 12:01 ` Lee Jones
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2016-03-30 8:23 UTC (permalink / raw)
To: Lee Jones; +Cc: Kishon Vijay Abraham I, linux-kernel
On 30.03.2016 17:10, Lee Jones wrote:
> On Wed, 30 Mar 2016, Lee Jones wrote:
>
>> On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote:
>>
>>> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
>>> allyesconfig (COMPILE_TEST) failed with:
>>>
>>> drivers/built-in.o: In function `omap_control_phy_probe':
>>> phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource'
>>> drivers/built-in.o: In function `cygnus_pcie_phy_probe':
>>> phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource'
>>>
>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>> ---
>>> drivers/phy/Kconfig | 2 ++
>>> 1 file changed, 2 insertions(+)
>>
>> Holding off on this until the discussion reaches some kind of
>> consensus.
>
> FYI: https://lkml.org/lkml/2016/3/29/716
Yeah, I saw it today.
But this is a little bit different. It is not caused by selecting
MFD_SYSCON but because of unlinked devres.o (which is linked by HAS_IOMEM).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM
2016-03-30 8:23 ` Krzysztof Kozlowski
@ 2016-03-30 12:01 ` Lee Jones
0 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2016-03-30 12:01 UTC (permalink / raw)
To: Krzysztof Kozlowski; +Cc: Kishon Vijay Abraham I, linux-kernel
On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote:
> On 30.03.2016 17:10, Lee Jones wrote:
> > On Wed, 30 Mar 2016, Lee Jones wrote:
> >
> >> On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote:
> >>
> >>> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um
> >>> allyesconfig (COMPILE_TEST) failed with:
> >>>
> >>> drivers/built-in.o: In function `omap_control_phy_probe':
> >>> phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource'
> >>> drivers/built-in.o: In function `cygnus_pcie_phy_probe':
> >>> phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource'
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >>> ---
> >>> drivers/phy/Kconfig | 2 ++
> >>> 1 file changed, 2 insertions(+)
> >>
> >> Holding off on this until the discussion reaches some kind of
> >> consensus.
> >
> > FYI: https://lkml.org/lkml/2016/3/29/716
>
> Yeah, I saw it today.
>
> But this is a little bit different. It is not caused by selecting
> MFD_SYSCON but because of unlinked devres.o (which is linked by HAS_IOMEM).
Discussion is continuing. Please follow it until conclusion, then
re-submit your patches (remembering to Cc the individuals in the
aforementioned conversation).
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-30 12:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-30 0:48 [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM Krzysztof Kozlowski
2016-03-30 8:08 ` Lee Jones
2016-03-30 8:10 ` Lee Jones
2016-03-30 8:23 ` Krzysztof Kozlowski
2016-03-30 12:01 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox