From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752413AbcC3LPM (ORCPT ); Wed, 30 Mar 2016 07:15:12 -0400 Received: from mga14.intel.com ([192.55.52.115]:11845 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751404AbcC3LPI (ORCPT ); Wed, 30 Mar 2016 07:15:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,415,1455004800"; d="scan'208";a="934630896" Date: Wed, 30 Mar 2016 14:15:01 +0300 From: Mika Westerberg To: Cristina Ciocan Cc: mathias.nyman@linux.intel.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, irina.tirdea@intel.com, octavian.purdila@intel.com Subject: Re: [PATCH v2 1/6] pinctrl: baytrail: Add pin control data structures Message-ID: <20160330111501.GS2099@lahna.fi.intel.com> References: <1459171780-24856-1-git-send-email-cristina.ciocan@intel.com> <1459171780-24856-2-git-send-email-cristina.ciocan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459171780-24856-2-git-send-email-cristina.ciocan@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 28, 2016 at 04:29:35PM +0300, Cristina Ciocan wrote: > +/* SCORE pins */ > +static const struct pinctrl_pin_desc byt_score_pins[] = { > + PINCTRL_PIN(0, "SATA_GP[0]"), /* GPIOC_0 */ > + PINCTRL_PIN(1, "SATA_GP[1]"), /* GPIOC_1 */ Maybe we should call these "SATA_GP0" and "SATA_GP1" like we do in other Intel pinctrl drivers? Also I don't think /* GPIOC_1 */ is really useful comment as that can be derived already from the pin number. Otherwise this looks good.