From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753289AbcC3MBi (ORCPT ); Wed, 30 Mar 2016 08:01:38 -0400 Received: from mail-wm0-f54.google.com ([74.125.82.54]:38828 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752056AbcC3MBg (ORCPT ); Wed, 30 Mar 2016 08:01:36 -0400 Date: Wed, 30 Mar 2016 13:01:24 +0100 From: Lee Jones To: Krzysztof Kozlowski Cc: Kishon Vijay Abraham I , linux-kernel@vger.kernel.org Subject: Re: [RESEND] phy: Fix build error of missing devm_ioremap_resource on UM Message-ID: <20160330120124.GL3323@x1> References: <1459298921-20410-1-git-send-email-k.kozlowski@samsung.com> <20160330080856.GB3323@x1> <20160330081036.GC3323@x1> <56FB8D0F.1010108@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56FB8D0F.1010108@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote: > On 30.03.2016 17:10, Lee Jones wrote: > > On Wed, 30 Mar 2016, Lee Jones wrote: > > > >> On Wed, 30 Mar 2016, Krzysztof Kozlowski wrote: > >> > >>> The devres.o gets linked if HAS_IOMEM is present so on ARCH=um > >>> allyesconfig (COMPILE_TEST) failed with: > >>> > >>> drivers/built-in.o: In function `omap_control_phy_probe': > >>> phy-omap-control.c:(.text+0x16db): undefined reference to `devm_ioremap_resource' > >>> drivers/built-in.o: In function `cygnus_pcie_phy_probe': > >>> phy-bcm-cygnus-pcie.c:(.text+0x1bfa): undefined reference to `devm_ioremap_resource' > >>> > >>> Signed-off-by: Krzysztof Kozlowski > >>> --- > >>> drivers/phy/Kconfig | 2 ++ > >>> 1 file changed, 2 insertions(+) > >> > >> Holding off on this until the discussion reaches some kind of > >> consensus. > > > > FYI: https://lkml.org/lkml/2016/3/29/716 > > Yeah, I saw it today. > > But this is a little bit different. It is not caused by selecting > MFD_SYSCON but because of unlinked devres.o (which is linked by HAS_IOMEM). Discussion is continuing. Please follow it until conclusion, then re-submit your patches (remembering to Cc the individuals in the aforementioned conversation). -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog