From: Wolfram Sang <wsa@the-dreams.de>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: linux-kernel@vger.kernel.org,
Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <mmarek@suse.com>,
cocci@systeme.lip6.fr
Subject: Re: [PATCH] scripts: coccinelle: remove check to move constants to right
Date: Wed, 30 Mar 2016 14:19:34 +0200 [thread overview]
Message-ID: <20160330121934.GA9329@katana> (raw)
In-Reply-To: <alpine.DEB.2.02.1603191840121.2259@localhost6.localdomain6>
[-- Attachment #1: Type: text/plain, Size: 770 bytes --]
On Sat, Mar 19, 2016 at 06:43:08PM +0100, Julia Lawall wrote:
> On Sat, 19 Mar 2016, Wolfram Sang wrote:
>
> > The header mentions this check depends on personal taste. I agree.
> > Running coccicheck on patches before I apply them, this SmPL produced
> > enough false positives for me that I'd rather see it removed.
>
> An improvement is coming up, that should be more acceptable. However,
> it's being held up by the need for some bug fixes in Coccinelle. A
> release of Coccinelle is planned for the beginning of April. Perhaps
> it is just as well to just remove this version for now.
>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
Michal, can we have that in v4.6 please? The false positives are
annoying...
Thanks,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-30 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-19 17:37 [PATCH] scripts: coccinelle: remove check to move constants to right Wolfram Sang
2016-03-19 17:43 ` Julia Lawall
2016-03-19 17:46 ` Wolfram Sang
2016-03-19 17:47 ` Julia Lawall
2016-03-30 12:19 ` Wolfram Sang [this message]
2016-04-20 7:57 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160330121934.GA9329@katana \
--to=wsa@the-dreams.de \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox