[PATCH] scripts: coccinelle: remove check to move constants to right

[PATCH] scripts: coccinelle: remove check to move constants to right

[Wolfram Sang]

The header mentions this check depends on personal taste. I agree.
Running coccicheck on patches before I apply them, this SmPL produced
enough false positives for me that I'd rather see it removed.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
 scripts/coccinelle/misc/compare_const_fl.cocci | 171 -------------------------
 1 file changed, 171 deletions(-)
 delete mode 100644 scripts/coccinelle/misc/compare_const_fl.cocci

diff --git a/scripts/coccinelle/misc/compare_const_fl.cocci b/scripts/coccinelle/misc/compare_const_fl.cocci
deleted file mode 100644
index b5d4bab60263dc..00000000000000
--- a/scripts/coccinelle/misc/compare_const_fl.cocci
+++ /dev/null
@@ -1,171 +0,0 @@
-/// Move constants to the right of binary operators.
-//# Depends on personal taste in some cases.
-///
-// Confidence: Moderate
-// Copyright: (C) 2015 Copyright: (C) 2015 Julia Lawall, Inria. GPLv2.
-// URL: http://coccinelle.lip6.fr/
-// Options: --no-includes --include-headers
-
-virtual patch
-virtual context
-virtual org
-virtual report
-
-@r1 depends on patch && !context && !org && !report
- disable bitor_comm, neg_if_exp@
-constant c,c1;
-local idexpression i;
-expression e,e1,e2;
-binary operator b = {==,!=,&,|};
-type t;
-@@
-
-(
-c b (c1)
-|
-sizeof(t) b e1
-|
-sizeof e b e1
-|
-i b e1
-|
-c | e1 | e2 | ...
-|
-c | (e ? e1 : e2)
-|
-- c
-+ e
-b
-- e
-+ c
-)
-
-@r2 depends on patch && !context && !org && !report
- disable gtr_lss, gtr_lss_eq, not_int2@
-constant c,c1;
-expression e,e1,e2;
-binary operator b;
-binary operator b1 = {<,<=},b2 = {<,<=};
-binary operator b3 = {>,>=},b4 = {>,>=};
-local idexpression i;
-type t;
-@@
-
-(
-c b c1
-|
-sizeof(t) b e1
-|
-sizeof e b e1
-|
- (e1 b1 e) && (e b2 e2)
-|
- (e1 b3 e) && (e b4 e2)
-|
-i b e
-|
-- c < e
-+ e > c
-|
-- c <= e
-+ e >= c
-|
-- c > e
-+ e < c
-|
-- c >= e
-+ e <= c
-)
-
-// ----------------------------------------------------------------------------
-
-@r1_context depends on !patch && (context || org || report)
- disable bitor_comm, neg_if_exp exists@
-type t;
-binary operator b = {==,!=,&,|};
-constant c, c1;
-expression e, e1, e2;
-local idexpression i;
-position j0;
-@@
-
-(
-c b (c1)
-|
-sizeof(t) b e1
-|
-sizeof e b e1
-|
-i b e1
-|
-c | e1 | e2 | ...
-|
-c | (e ? e1 : e2)
-|
-* c@j0 b e
-)
-
-@r2_context depends on !patch && (context || org || report)
- disable gtr_lss, gtr_lss_eq, not_int2 exists@
-type t;
-binary operator b, b1 = {<,<=}, b2 = {<,<=}, b3 = {>,>=}, b4 = {>,>=};
-constant c, c1;
-expression e, e1, e2;
-local idexpression i;
-position j0;
-@@
-
-(
-c b c1
-|
-sizeof(t) b e1
-|
-sizeof e b e1
-|
- (e1 b1 e) && (e b2 e2)
-|
- (e1 b3 e) && (e b4 e2)
-|
-i b e
-|
-* c@j0 < e
-|
-* c@j0 <= e
-|
-* c@j0 > e
-|
-* c@j0 >= e
-)
-
-// ----------------------------------------------------------------------------
-
-@script:python r1_org depends on org@
-j0 << r1_context.j0;
-@@
-
-msg = "Move constant to right."
-coccilib.org.print_todo(j0[0], msg)
-
-@script:python r2_org depends on org@
-j0 << r2_context.j0;
-@@
-
-msg = "Move constant to right."
-coccilib.org.print_todo(j0[0], msg)
-
-// ----------------------------------------------------------------------------
-
-@script:python r1_report depends on report@
-j0 << r1_context.j0;
-@@
-
-msg = "Move constant to right."
-coccilib.report.print_report(j0[0], msg)
-
-@script:python r2_report depends on report@
-j0 << r2_context.j0;
-@@
-
-msg = "Move constant to right."
-coccilib.report.print_report(j0[0], msg)
-
-- 
2.6.2

Re: [PATCH] scripts: coccinelle: remove check to move constants to right

[Julia Lawall]

On Sat, 19 Mar 2016, Wolfram Sang wrote:

> The header mentions this check depends on personal taste. I agree.
> Running coccicheck on patches before I apply them, this SmPL produced
> enough false positives for me that I'd rather see it removed.

An improvement is coming up, that should be more acceptable.  However, 
it's being held up by the need for some bug fixes in Coccinelle.  A 
release of Coccinelle is planned for the beginning of April.  Perhaps 
it is just as well to just remove this version for now.

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

julia

> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
>  scripts/coccinelle/misc/compare_const_fl.cocci | 171 -------------------------
>  1 file changed, 171 deletions(-)
>  delete mode 100644 scripts/coccinelle/misc/compare_const_fl.cocci
> 
> diff --git a/scripts/coccinelle/misc/compare_const_fl.cocci b/scripts/coccinelle/misc/compare_const_fl.cocci
> deleted file mode 100644
> index b5d4bab60263dc..00000000000000
> --- a/scripts/coccinelle/misc/compare_const_fl.cocci
> +++ /dev/null
> @@ -1,171 +0,0 @@
> -/// Move constants to the right of binary operators.
> -//# Depends on personal taste in some cases.
> -///
> -// Confidence: Moderate
> -// Copyright: (C) 2015 Copyright: (C) 2015 Julia Lawall, Inria. GPLv2.
> -// URL: http://coccinelle.lip6.fr/
> -// Options: --no-includes --include-headers
> -
> -virtual patch
> -virtual context
> -virtual org
> -virtual report
> -
> -@r1 depends on patch && !context && !org && !report
> - disable bitor_comm, neg_if_exp@
> -constant c,c1;
> -local idexpression i;
> -expression e,e1,e2;
> -binary operator b = {==,!=,&,|};
> -type t;
> -@@
> -
> -(
> -c b (c1)
> -|
> -sizeof(t) b e1
> -|
> -sizeof e b e1
> -|
> -i b e1
> -|
> -c | e1 | e2 | ...
> -|
> -c | (e ? e1 : e2)
> -|
> -- c
> -+ e
> -b
> -- e
> -+ c
> -)
> -
> -@r2 depends on patch && !context && !org && !report
> - disable gtr_lss, gtr_lss_eq, not_int2@
> -constant c,c1;
> -expression e,e1,e2;
> -binary operator b;
> -binary operator b1 = {<,<=},b2 = {<,<=};
> -binary operator b3 = {>,>=},b4 = {>,>=};
> -local idexpression i;
> -type t;
> -@@
> -
> -(
> -c b c1
> -|
> -sizeof(t) b e1
> -|
> -sizeof e b e1
> -|
> - (e1 b1 e) && (e b2 e2)
> -|
> - (e1 b3 e) && (e b4 e2)
> -|
> -i b e
> -|
> -- c < e
> -+ e > c
> -|
> -- c <= e
> -+ e >= c
> -|
> -- c > e
> -+ e < c
> -|
> -- c >= e
> -+ e <= c
> -)
> -
> -// ----------------------------------------------------------------------------
> -
> -@r1_context depends on !patch && (context || org || report)
> - disable bitor_comm, neg_if_exp exists@
> -type t;
> -binary operator b = {==,!=,&,|};
> -constant c, c1;
> -expression e, e1, e2;
> -local idexpression i;
> -position j0;
> -@@
> -
> -(
> -c b (c1)
> -|
> -sizeof(t) b e1
> -|
> -sizeof e b e1
> -|
> -i b e1
> -|
> -c | e1 | e2 | ...
> -|
> -c | (e ? e1 : e2)
> -|
> -* c@j0 b e
> -)
> -
> -@r2_context depends on !patch && (context || org || report)
> - disable gtr_lss, gtr_lss_eq, not_int2 exists@
> -type t;
> -binary operator b, b1 = {<,<=}, b2 = {<,<=}, b3 = {>,>=}, b4 = {>,>=};
> -constant c, c1;
> -expression e, e1, e2;
> -local idexpression i;
> -position j0;
> -@@
> -
> -(
> -c b c1
> -|
> -sizeof(t) b e1
> -|
> -sizeof e b e1
> -|
> - (e1 b1 e) && (e b2 e2)
> -|
> - (e1 b3 e) && (e b4 e2)
> -|
> -i b e
> -|
> -* c@j0 < e
> -|
> -* c@j0 <= e
> -|
> -* c@j0 > e
> -|
> -* c@j0 >= e
> -)
> -
> -// ----------------------------------------------------------------------------
> -
> -@script:python r1_org depends on org@
> -j0 << r1_context.j0;
> -@@
> -
> -msg = "Move constant to right."
> -coccilib.org.print_todo(j0[0], msg)
> -
> -@script:python r2_org depends on org@
> -j0 << r2_context.j0;
> -@@
> -
> -msg = "Move constant to right."
> -coccilib.org.print_todo(j0[0], msg)
> -
> -// ----------------------------------------------------------------------------
> -
> -@script:python r1_report depends on report@
> -j0 << r1_context.j0;
> -@@
> -
> -msg = "Move constant to right."
> -coccilib.report.print_report(j0[0], msg)
> -
> -@script:python r2_report depends on report@
> -j0 << r2_context.j0;
> -@@
> -
> -msg = "Move constant to right."
> -coccilib.report.print_report(j0[0], msg)
> -
> -- 
> 2.6.2
> 
> 

Re: [PATCH] scripts: coccinelle: remove check to move constants to right

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]

On Sat, Mar 19, 2016 at 06:43:08PM +0100, Julia Lawall wrote:
> On Sat, 19 Mar 2016, Wolfram Sang wrote:
> 
> > The header mentions this check depends on personal taste. I agree.
> > Running coccicheck on patches before I apply them, this SmPL produced
> > enough false positives for me that I'd rather see it removed.
> 
> An improvement is coming up, that should be more acceptable.  However, 
> it's being held up by the need for some bug fixes in Coccinelle.  A 
> release of Coccinelle is planned for the beginning of April.  Perhaps 
> it is just as well to just remove this version for now.
> 
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Thanks, Julia. If you put me on CC of the new version, I'll be happy to
test.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] scripts: coccinelle: remove check to move constants to right

[Julia Lawall]

On Sat, 19 Mar 2016, Wolfram Sang wrote:

> On Sat, Mar 19, 2016 at 06:43:08PM +0100, Julia Lawall wrote:
> > On Sat, 19 Mar 2016, Wolfram Sang wrote:
> > 
> > > The header mentions this check depends on personal taste. I agree.
> > > Running coccicheck on patches before I apply them, this SmPL produced
> > > enough false positives for me that I'd rather see it removed.
> > 
> > An improvement is coming up, that should be more acceptable.  However, 
> > it's being held up by the need for some bug fixes in Coccinelle.  A 
> > release of Coccinelle is planned for the beginning of April.  Perhaps 
> > it is just as well to just remove this version for now.
> > 
> > Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> 
> Thanks, Julia. If you put me on CC of the new version, I'll be happy to
> test.

Thanks :)

julia

Re: [PATCH] scripts: coccinelle: remove check to move constants to right

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

On Sat, Mar 19, 2016 at 06:43:08PM +0100, Julia Lawall wrote:
> On Sat, 19 Mar 2016, Wolfram Sang wrote:
> 
> > The header mentions this check depends on personal taste. I agree.
> > Running coccicheck on patches before I apply them, this SmPL produced
> > enough false positives for me that I'd rather see it removed.
> 
> An improvement is coming up, that should be more acceptable.  However, 
> it's being held up by the need for some bug fixes in Coccinelle.  A 
> release of Coccinelle is planned for the beginning of April.  Perhaps 
> it is just as well to just remove this version for now.
> 
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Michal, can we have that in v4.6 please? The false positives are
annoying...

Thanks,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] scripts: coccinelle: remove check to move constants to right

[Michal Marek]

On Sat, Mar 19, 2016 at 06:43:08PM +0100, Julia Lawall wrote:
> On Sat, 19 Mar 2016, Wolfram Sang wrote:
> 
> > The header mentions this check depends on personal taste. I agree.
> > Running coccicheck on patches before I apply them, this SmPL produced
> > enough false positives for me that I'd rather see it removed.
> 
> An improvement is coming up, that should be more acceptable.  However, 
> it's being held up by the need for some bug fixes in Coccinelle.  A 
> release of Coccinelle is planned for the beginning of April.  Perhaps 
> it is just as well to just remove this version for now.
> 
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Applied to kbuild.git#misc.

Michal