Re: [PATCH v2 1/6] pinctrl: baytrail: Add pin control data structures

Cristina Ciocan
2016-03-30T11:30:27Z

On 30.03.2016 14:15, Mika Westerberg wrote:
> On Mon, Mar 28, 2016 at 04:29:35PM +0300, Cristina Ciocan wrote:
>> +/* SCORE pins */
>> +static const struct pinctrl_pin_desc byt_score_pins[] = {
>> + PINCTRL_PIN(0, "SATA_GP[0]"), /* GPIOC_0 */
>> + PINCTRL_PIN(1, "SATA_GP[1]"), /* GPIOC_1 */
>
> Maybe we should call these "SATA_GP0" and "SATA_GP1" like we do in other
> Intel pinctrl drivers?

The names are directly taken form the public datasheet found at:
http://www.intel.com/content/www/us/en/embedded/products/bay-trail/atom-e3800-family-datasheet.html,
section 10.3, Ball Name and Function by Location.

I kept those names, even though they are not always pretty, so that teh
pins can be easily identified if someone searches them in the datasheet
for extra information.

>
> Also I don't think /* GPIOC_1 */ is really useful comment as that can be
> derived already from the pin number.

The issue here is that pins are not referenced by the same name in the
datasheet. In the above mentioned section (10.3), south core pins are
GPIO_S0_SC[<pin_number>], whereas in the GPIO section (39) they are
referenced as GPIOC_<pin_number>. I added the comments for the same
reasoning as above, easy search for datasheet-driver pin matching.

If this is not an issue, I can change both names and comments.

Thank you for the review.

>
> Otherwise this looks good.
>