From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758664AbcC3HUy (ORCPT ); Wed, 30 Mar 2016 03:20:54 -0400 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:58110 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754047AbcC3HUx (ORCPT ); Wed, 30 Mar 2016 03:20:53 -0400 Date: Wed, 30 Mar 2016 15:16:29 +0800 From: Jisheng Zhang To: Daniel Lezcano CC: , , Subject: Re: [PATCH 1/2] ARM: cpuidle: fix !cpuidle_ops[cpu].init case during init Message-ID: <20160330151629.0b338365@xhacker> In-Reply-To: <56F52502.3060308@linaro.org> References: <1458796269-6158-1-git-send-email-jszhang@marvell.com> <1458796269-6158-2-git-send-email-jszhang@marvell.com> <56F52502.3060308@linaro.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-03-30_04:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1603300106 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, On Fri, 25 Mar 2016 12:46:10 +0100 Daniel Lezcano wrote: > On 03/24/2016 06:11 AM, Jisheng Zhang wrote: > > Let's assume cpuidle_ops exists but it doesn't implement the according > > init member, current arm_cpuidle_init() will return success to its > > caller, but in fact it should return -EOPNOTSUPP. > > > > Signed-off-by: Jisheng Zhang > > --- > > arch/arm/kernel/cpuidle.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/kernel/cpuidle.c b/arch/arm/kernel/cpuidle.c > > index 703926e..f108d8f 100644 > > --- a/arch/arm/kernel/cpuidle.c > > +++ b/arch/arm/kernel/cpuidle.c > > @@ -143,8 +143,12 @@ int __init arm_cpuidle_init(int cpu) > > return -ENODEV; > > > > ret = arm_cpuidle_read_ops(cpu_node, cpu); > > - if (!ret && cpuidle_ops[cpu].init) > > - ret = cpuidle_ops[cpu].init(cpu_node, cpu); > > + if (!ret) { > > + if (cpuidle_ops[cpu].init) > > + ret = cpuidle_ops[cpu].init(cpu_node, cpu); > > + else > > + ret = -EOPNOTSUPP; > > + } > > Hi Jisheng, > > this should be handled in the arm_cpuidle_read_ops function. > Thanks for reviewing. After some consideration, I think this patch isn't correct There may be platforms which doesn't need the init member at all, although currently I don't see such platforms in mainline, So I'll drop this patch and send out one v2 only does the optimization. Thanks a lot, Jisheng