From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751278AbcCaIEn (ORCPT ); Thu, 31 Mar 2016 04:04:43 -0400 Received: from mga03.intel.com ([134.134.136.65]:30585 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755149AbcCaIEj (ORCPT ); Thu, 31 Mar 2016 04:04:39 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,421,1455004800"; d="scan'208";a="922410213" Date: Thu, 31 Mar 2016 11:04:34 +0300 From: Mika Westerberg To: Cristina Ciocan Cc: mathias.nyman@linux.intel.com, heikki.krogerus@linux.intel.com, linus.walleij@linaro.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, irina.tirdea@intel.com, octavian.purdila@intel.com Subject: Re: [PATCH v3 1/6] pinctrl: baytrail: Add pin control data structures Message-ID: <20160331080434.GE2099@lahna.fi.intel.com> References: <1459350335-15192-1-git-send-email-cristina.ciocan@intel.com> <1459350335-15192-2-git-send-email-cristina.ciocan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459350335-15192-2-git-send-email-cristina.ciocan@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 30, 2016 at 06:05:30PM +0300, Cristina Ciocan wrote: > + PINCTRL_PIN(55, "GPIO_S0_SC[055]"), > + PINCTRL_PIN(56, "GPIO_S0_SC[056]"), > + PINCTRL_PIN(57, "GPIO_S0_SC[057]"), > + PINCTRL_PIN(58, "GPIO_S0_SC[058]"), > + PINCTRL_PIN(59, "GPIO_S0_SC[059]"), > + PINCTRL_PIN(60, "GPIO_S0_SC[060]"), > + PINCTRL_PIN(61, "GPIO_S0_SC[061]"), You still have these (and all similar [number]) things. IMO this looks better: PINCTRL_PIN(55, "GPIO_S0_SC55"), PINCTRL_PIN(56, "GPIO_S0_SC56"), PINCTRL_PIN(57, "GPIO_S0_SC57"), PINCTRL_PIN(58, "GPIO_S0_SC58"), PINCTRL_PIN(59, "GPIO_S0_SC59"), PINCTRL_PIN(60, "GPIO_S0_SC60"), PINCTRL_PIN(61, "GPIO_S0_SC61"), but I don't really care that much ;-) My ack still applies to the whole series.