From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755183AbcCaKR3 (ORCPT ); Thu, 31 Mar 2016 06:17:29 -0400 Received: from mga02.intel.com ([134.134.136.20]:12323 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751654AbcCaKR2 (ORCPT ); Thu, 31 Mar 2016 06:17:28 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,421,1455004800"; d="scan'208";a="922484655" Date: Thu, 31 Mar 2016 13:17:13 +0300 From: Jarkko Sakkinen To: Christophe Ricard Cc: Marcel Selhorst , Jason Gunthorpe , "moderated list:TPM DEVICE DRIVER" , open list , Peter Huewe Subject: Re: [PATCH] tpm: cleanup tpm_tis_remove() Message-ID: <20160331101713.GB20686@intel.com> References: <1459419087-20487-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160331101536.GA20686@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160331101536.GA20686@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 31, 2016 at 01:15:36PM +0300, Jarkko Sakkinen wrote: > Christophe, > > On Thu, Mar 31, 2016 at 01:11:27PM +0300, Jarkko Sakkinen wrote: > > Created a local variable for the register in order to clean up > > experession where TPM_GLOBAL_INT_ENABLE is cleared. This expression is > > horrible to read and makes changing the function uncomfortable because > > like easily surpass 80 characters. > > Can you test this patch your hardware and reply with Tested-by tag if it > does? I can then update your iobase patch to apply on top of this. > > I thought it was better idea to simplify the expression a little bit > than make it even worse mess. And yes I'll fix all the typos in the commit msg in this patch before applying it :) /Jarkko