From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Christophe Ricard <christophe-h.ricard@st.com>
Cc: Marcel Selhorst <tpmdd@selhorst.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>,
Peter Huewe <peterhuewe@gmx.de>
Subject: Re: [PATCH] tpm: cleanup tpm_tis_remove()
Date: Thu, 31 Mar 2016 13:29:58 +0300 [thread overview]
Message-ID: <20160331102958.GA22364@intel.com> (raw)
In-Reply-To: <20160331101713.GB20686@intel.com>
On Thu, Mar 31, 2016 at 01:17:13PM +0300, Jarkko Sakkinen wrote:
> On Thu, Mar 31, 2016 at 01:15:36PM +0300, Jarkko Sakkinen wrote:
> > Christophe,
> >
> > On Thu, Mar 31, 2016 at 01:11:27PM +0300, Jarkko Sakkinen wrote:
> > > Created a local variable for the register in order to clean up
> > > experession where TPM_GLOBAL_INT_ENABLE is cleared. This expression is
> > > horrible to read and makes changing the function uncomfortable because
> > > like easily surpass 80 characters.
> >
> > Can you test this patch your hardware and reply with Tested-by tag if it
> > does? I can then update your iobase patch to apply on top of this.
> >
> > I thought it was better idea to simplify the expression a little bit
> > than make it even worse mess.
>
> And yes I'll fix all the typos in the commit msg in this patch before
> applying it :)
I committed this to my master branch with the option to drop if there it
does not get reviewed/tested-by's (which I doubt). Since this touches
multiple patches (locality patch too) and in addition there was couple
glitches maybe it would be good if you would prepare one more round of
the series if you don't mind?
/Jarkko
next prev parent reply other threads:[~2016-03-31 10:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 10:11 [PATCH] tpm: cleanup tpm_tis_remove() Jarkko Sakkinen
2016-03-31 10:15 ` Jarkko Sakkinen
2016-03-31 10:17 ` Jarkko Sakkinen
2016-03-31 10:29 ` Jarkko Sakkinen [this message]
2016-03-31 10:33 ` Christophe Henri RICARD
2016-03-31 14:55 ` Christophe Henri RICARD
2016-03-31 16:19 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331102958.GA22364@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=christophe-h.ricard@st.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox