From: Yuyang Du <yuyang.du@intel.com>
To: bsegall@google.com
Cc: peterz@infradead.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, pjt@google.com,
morten.rasmussen@arm.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, lizefan@huawei.com,
umgwanakikbuti@gmail.com
Subject: Re: [PATCH RESEND v2 6/6] sched/fair: Remove unconditionally inactive code
Date: Fri, 1 Apr 2016 07:20:59 +0800 [thread overview]
Message-ID: <20160331232059.GE22689@intel.com> (raw)
In-Reply-To: <xm26h9fma60x.fsf@bsegall-linux.mtv.corp.google.com>
On Thu, Mar 31, 2016 at 10:53:02AM -0700, bsegall@google.com wrote:
> Yuyang Du <yuyang.du@intel.com> writes:
>
> > The increased load resolution (fixed point arithmetic range) is
> > unconditionally deactivated with #if 0, so it is effectively broken.
> >
> > But the increased load range is still used somewhere (e.g., in Google),
> > so we keep this feature. The reconciliation is we define
> > CONFIG_CFS_INCREASE_LOAD_RANGE and it depends on FAIR_GROUP_SCHED and
> > 64BIT and BROKEN.
> >
> > Suggested-by: Ingo Molnar <mingo@kernel.org>
> > Signed-off-by: Yuyang Du <yuyang.du@intel.com>
>
> The title of this patch "Remove unconditionally inactive code" is
> misleading since it's more like giving it a CONFIG.
Reasonable argument.
>
> Also as a side note, does anyone remember/have a test for whatever got
> it turned off to begin with, given all the changes in load tracking and
> the load balancer and everything else?
It is this commit that turned it off:
Commit e4c2fb0d5776: "sched: Disable (revert) SCHED_LOAD_SCALE increase"
prev parent reply other threads:[~2016-04-01 7:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 20:16 [PATCH RESEND v2 0/6] sched/fair: Clean up sched metric definitions Yuyang Du
2016-03-30 20:16 ` [PATCH RESEND v2 1/6] sched/fair: Generalize the load/util averages resolution definition Yuyang Du
2016-03-30 20:16 ` [PATCH RESEND v2 2/6] sched/fair: Remove SCHED_LOAD_SHIFT and SCHED_LOAD_SCALE Yuyang Du
2016-03-30 20:16 ` [PATCH RESEND v2 3/6] sched/fair: Add introduction to the sched load avg metrics Yuyang Du
2016-03-30 20:16 ` [PATCH RESEND v2 4/6] sched/fair: Remove scale_load_down() for load_avg Yuyang Du
2016-03-31 17:45 ` bsegall
2016-03-30 20:16 ` [PATCH RESEND v2 5/6] sched/fair: Rename scale_load() and scale_load_down() Yuyang Du
2016-03-30 20:16 ` [PATCH RESEND v2 6/6] sched/fair: Remove unconditionally inactive code Yuyang Du
2016-03-31 17:53 ` bsegall
2016-03-31 23:20 ` Yuyang Du [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331232059.GE22689@intel.com \
--to=yuyang.du@intel.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@kernel.org \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=umgwanakikbuti@gmail.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox