From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757928AbcDACfQ (ORCPT ); Thu, 31 Mar 2016 22:35:16 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:33999 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752210AbcDACfO (ORCPT ); Thu, 31 Mar 2016 22:35:14 -0400 Date: Thu, 31 Mar 2016 18:35:10 -0800 From: Kent Overstreet To: Andrew Morton Cc: Al Viro , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: Refactor find_get_pages() & friends Message-ID: <20160401023510.GA28762@kmo-pixel> References: <20160309011643.GA23179@kmo-pixel> <20160329142911.f2b069c8af06f649b86ec993@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160329142911.f2b069c8af06f649b86ec993@linux-foundation.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 29, 2016 at 02:29:11PM -0700, Andrew Morton wrote: > On Tue, 8 Mar 2016 16:16:43 -0900 Kent Overstreet wrote: > > > Collapse redundant implementations of various gang pagecache lookup - this is > > also prep work for pagecache iterator work > > Patch looks nice. Unfortunately filemap.c has changed rather a lot > since 4.5. Can you please redo the patch some time? > > And a more informative changelog would be appropriate, although it's > all pretty obvious. I don't know what "pagecache iterator work" is > and I doubt if many other readers do either, so some illumination there > wouldn't hurt. Can do - sending you the pagecache iterator patch too: Kent Overstreet (2): mm: Refactor find_get_pages() & friends mm: Real pagecache iterators fs/ext4/inode.c | 261 +++++++++++++------------------ include/linux/pagemap.h | 142 +++++++++++++++-- include/linux/pagevec.h | 67 +++++++- include/linux/radix-tree.h | 49 ++---- mm/filemap.c | 376 ++++++++++----------------------------------- mm/page-writeback.c | 148 ++++++++---------- mm/swap.c | 33 +--- mm/truncate.c | 259 ++++++++++++------------------- 8 files changed, 546 insertions(+), 789 deletions(-) -- 2.8.0.rc3