From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758681AbcDADaK (ORCPT ); Thu, 31 Mar 2016 23:30:10 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:59950 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758587AbcDADaI (ORCPT ); Thu, 31 Mar 2016 23:30:08 -0400 Date: Fri, 1 Apr 2016 04:30:06 +0100 From: Al Viro To: Eric Biggers Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] vfs: constify arguments to utime family of system calls Message-ID: <20160401033006.GB17997@ZenIV.linux.org.uk> References: <1459475472-13104-1-git-send-email-ebiggers3@gmail.com> <20160401020524.GA17997@ZenIV.linux.org.uk> <20160401022457.GC1323@zzz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160401022457.GC1323@zzz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 31, 2016 at 09:24:57PM -0500, Eric Biggers wrote: > I feel it's a small improvement as it reduces the chance of bugs. However, if > you look at all the system calls, they are, in general, inconsistent about using > 'const'. So may be right that changing just a few isn't worthwhile. It might very well be worth doing a full series, though - after all, they are not hard to grep for ((COMPAT_)?SYSCALL_DEFINE[0-6] would get you almost all of them, with rest consisting of weird shit in arch/* that more often than not would be better off switched to SYSCALL_DEFINE). The reason why it's worth doing completely or not at all is that partial series will serve as an invitation to the alt.sex.masturbation.commit.count crowd, with the usual quality of output...