From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758120AbcDAGAX (ORCPT ); Fri, 1 Apr 2016 02:00:23 -0400 Received: from mail-ig0-f180.google.com ([209.85.213.180]:37504 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753428AbcDAGAV (ORCPT ); Fri, 1 Apr 2016 02:00:21 -0400 Date: Fri, 1 Apr 2016 01:00:18 -0500 From: Eric Biggers To: linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, jaegeuk@kernel.org, tytso@mit.edu, mhalcrow@google.com Subject: Legal characters in encrypted fscrypto (f2fs/ext4) filename? Message-ID: <20160401060018.GD1323@zzz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, While reviewing the new filesystem encryption code, I was confused by the intended set of legal characters in the printable form of an encrypted filename. According to the actual code in fs/crypto/fname.c, the legal characters are: a-zA-Z0-9+, Alternatively, according to the comment in the same file, the legal characters are actually: a-zA-Z0-9+_ Still alternatively, according to the design document[1], the legal characters are actually: a-zA-Z0-9+= Which one is correct? [1] https://docs.google.com/document/d/1ft26lUQyuSpiu6VleP70_npaWdRfXFoNnB8JYnykNTg/preview?pref=2&pli=1#