From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753336AbcDAJPT (ORCPT ); Fri, 1 Apr 2016 05:15:19 -0400 Received: from casper.infradead.org ([85.118.1.10]:41912 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750701AbcDAJPQ (ORCPT ); Fri, 1 Apr 2016 05:15:16 -0400 Date: Fri, 1 Apr 2016 11:15:07 +0200 From: Peter Zijlstra To: Juergen Gross Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, mingo@redhat.com, Douglas_Warzecha@dell.com, pali.rohar@gmail.com, jdelvare@suse.com, linux@roeck-us.net, tglx@linutronix.de, hpa@zytor.com, jeremy@goop.org, chrisw@sous-sol.org, akataria@vmware.com, rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org, x86@kernel.org Subject: Re: [PATCH v3 5/6] virt, sched: add cpu pinning to smp_call_sync_on_phys_cpu() Message-ID: <20160401091507.GG3448@twins.programming.kicks-ass.net> References: <1459494874-12194-1-git-send-email-jgross@suse.com> <1459494874-12194-6-git-send-email-jgross@suse.com> <20160401074325.GC12845@twins.programming.kicks-ass.net> <56FE313E.9060804@suse.com> <20160401084408.GF3448@twins.programming.kicks-ass.net> <56FE3959.2030508@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56FE3959.2030508@suse.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 01, 2016 at 11:03:21AM +0200, Juergen Gross wrote: > > Maybe just make the vpin thing an option like: > > > > smp_call_on_cpu(int (*func)(void *), int phys_cpu); > > Also; is something like the vpin thing possible on KVM? because if we're > > going to expose it to generic code like this we had maybe look at wider > > support. > > It is necessary for dom0 under Xen. I don't think there is a need to do > this on KVM as a guest has no direct access to e.g. BIOS functions of > the real hardware and the host system needs no vcpu pinning. I'm not > sure about VMWare. OK, then can we WARN if .phys=1 and the platform doesn't support it?