From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754693AbcDALDF (ORCPT ); Fri, 1 Apr 2016 07:03:05 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:20007 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750963AbcDALDD (ORCPT ); Fri, 1 Apr 2016 07:03:03 -0400 Date: Fri, 1 Apr 2016 14:02:48 +0300 From: Dan Carpenter To: "Michael S. Tsirkin" Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [patch] virtio: silence uninitialized variable warnings Message-ID: <20160401110248.GA6048@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Most ->get() functions seem to call BUG_ON() if offset + len is out of range, but rproc_virtio_get() returns early without initializing ret. Presumably it can't actually happen but it leads to a static checker warning. Let's just initialize "ret". Signed-off-by: Dan Carpenter diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h index 6e6cb0c9..597dbef 100644 --- a/include/linux/virtio_config.h +++ b/include/linux/virtio_config.h @@ -334,7 +334,7 @@ static inline void virtio_cread_bytes(struct virtio_device *vdev, static inline u8 virtio_cread8(struct virtio_device *vdev, unsigned int offset) { - u8 ret; + u8 ret = 0; vdev->config->get(vdev, offset, &ret, sizeof(ret)); return ret; } @@ -348,7 +348,7 @@ static inline void virtio_cwrite8(struct virtio_device *vdev, static inline u16 virtio_cread16(struct virtio_device *vdev, unsigned int offset) { - u16 ret; + u16 ret = 0; vdev->config->get(vdev, offset, &ret, sizeof(ret)); return virtio16_to_cpu(vdev, (__force __virtio16)ret); } @@ -363,7 +363,7 @@ static inline void virtio_cwrite16(struct virtio_device *vdev, static inline u32 virtio_cread32(struct virtio_device *vdev, unsigned int offset) { - u32 ret; + u32 ret = 0; vdev->config->get(vdev, offset, &ret, sizeof(ret)); return virtio32_to_cpu(vdev, (__force __virtio32)ret); } @@ -378,7 +378,7 @@ static inline void virtio_cwrite32(struct virtio_device *vdev, static inline u64 virtio_cread64(struct virtio_device *vdev, unsigned int offset) { - u64 ret; + u64 ret = 0; __virtio_cread_many(vdev, offset, &ret, 1, sizeof(ret)); return virtio64_to_cpu(vdev, (__force __virtio64)ret); }