From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758767AbcDAMxm (ORCPT ); Fri, 1 Apr 2016 08:53:42 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:35039 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752102AbcDAMxk (ORCPT ); Fri, 1 Apr 2016 08:53:40 -0400 Date: Fri, 1 Apr 2016 14:53:37 +0200 From: Pavel Machek To: Jacek Anaszewski Cc: Heiner Kallweit , pali.rohar@gmail.com, sre@kernel.org, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, Greg KH , linux-leds@vger.kernel.org, Benjamin Tissoires , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v5 1/4] leds: core: add generic support for RGB Color LED's Message-ID: <20160401125337.GB11860@amd> References: <56D608ED.2090406@gmail.com> <20160329100258.GA24964@amd> <56FAE7A8.2070302@gmail.com> <20160329214323.GA10455@amd> <56FB893C.60203@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56FB893C.60203@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > >Ideally, I'd like to have "triggers", but different ones. As in: if > >charging, do yellow " .xX" pattern. If fully charged, do green steady > >light. If message is waiting, do blue " x x" pattern. If none of > >above, do slow white blinking. (Plus priorities of events). But that's > >quite different from existing support...) > > Please note that HSV colour scheme allows to neatly project monochrome > brightness semantics on the RGB realm. I.e. you can have fixed > hue and saturation, and by changing the brightness component a perceived > colour intensity can be altered. Yes, that's nice, but it is incompatible with already existing RGB support in kernel. Plus, echoing hue into file called brightness is extremely ugly, and it violates sysfs rules. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html