From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755435AbcDAXUa (ORCPT ); Fri, 1 Apr 2016 19:20:30 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:35307 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755259AbcDAXU1 (ORCPT ); Fri, 1 Apr 2016 19:20:27 -0400 Date: Fri, 1 Apr 2016 15:20:21 -0800 From: Kent Overstreet To: Andrew Morton Cc: Al Viro , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] mm: Real pagecache iterators Message-ID: <20160401232021.GA16071@kmo-pixel> References: <20160401023510.GA28762@kmo-pixel> <1459478291-29982-1-git-send-email-kent.overstreet@gmail.com> <1459478291-29982-2-git-send-email-kent.overstreet@gmail.com> <20160401155747.249e0f8ed89e00fbb24111d2@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160401155747.249e0f8ed89e00fbb24111d2@linux-foundation.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 01, 2016 at 03:57:47PM -0700, Andrew Morton wrote: > On Thu, 31 Mar 2016 18:38:11 -0800 Kent Overstreet wrote: > > > Introduce for_each_pagecache_page() and related macros, with the goal of > > replacing most/all uses of pagevec_lookup(). > > > > For the most part this shouldn't be a functional change. The one functional > > difference with the new macros is that they now take an @end parameter, so we're > > able to avoid grabbing pages in __find_get_pages() that we'll never use. > > > > This patch only does some of the conversions, the ones I was able to easily test > > myself - the conversions are mechanical but tricky enough they generally warrent > > testing. > > What is the reason for this change? I just got tired of code being hard to follow when I was trying to work on some pagecache invalidation stuff.