From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752533AbcDCHpL (ORCPT ); Sun, 3 Apr 2016 03:45:11 -0400 Received: from imap.thunk.org ([74.207.234.97]:33986 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751965AbcDCHpJ (ORCPT ); Sun, 3 Apr 2016 03:45:09 -0400 Date: Sun, 3 Apr 2016 03:45:05 -0400 From: "Theodore Ts'o" To: Eric Biggers Cc: linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, jaegeuk@kernel.org, mhalcrow@google.com Subject: Re: [PATCH 02/13] fscrypto: rename some functions for clarity Message-ID: <20160403074505.GG3334@thunk.org> Mail-Followup-To: Theodore Ts'o , Eric Biggers , linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, jaegeuk@kernel.org, mhalcrow@google.com References: <1459660924-2960-1-git-send-email-ebiggers3@gmail.com> <1459660924-2960-3-git-send-email-ebiggers3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459660924-2960-3-git-send-email-ebiggers3@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 03, 2016 at 12:21:53AM -0500, Eric Biggers wrote: > Rename fscrypt_complete() to page_crypt_complete(). This callback is > specifically for data pages; fscrypto also performs filename encryption. > > Rename dir_crypt_complete() to fname_crypt_complete(). This callback is > also used for symlink targets, not just directory entries. > > Rename fscrypt_process_policy() to fscrypt_set_policy(). The new name > better matches the ioctl, and it goes along with fscrypt_get_policy(). > > Signed-off-by: Eric Biggers I'd really rather not renaming any globally visible functions until after ext4 is converted over to use fs/crypto, just to avoid confusion. Cheers, - Ted