From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755633AbcDDPjg (ORCPT ); Mon, 4 Apr 2016 11:39:36 -0400 Received: from mail5.windriver.com ([192.103.53.11]:58780 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752590AbcDDPjf (ORCPT ); Mon, 4 Apr 2016 11:39:35 -0400 Date: Mon, 4 Apr 2016 11:39:28 -0400 From: Paul Gortmaker To: Krzysztof Kozlowski CC: , Chanwoo Choi , Samuel Ortiz , Lee Jones Subject: Re: [PATCH 6/7] drivers/mfd: make max77693.c explicitly non-modular Message-ID: <20160404153927.GM1778@windriver.com> References: <1459718659-28316-1-git-send-email-paul.gortmaker@windriver.com> <1459718659-28316-7-git-send-email-paul.gortmaker@windriver.com> <5701E53E.50202@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5701E53E.50202@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Re: [PATCH 6/7] drivers/mfd: make max77693.c explicitly non-modular] On 04/04/2016 (Mon 12:53) Krzysztof Kozlowski wrote: > On 04.04.2016 06:24, Paul Gortmaker wrote: [...] > > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c > > index b83b7a7da1ae..4126a55269d2 100644 > > --- a/drivers/mfd/max77693.c > > +++ b/drivers/mfd/max77693.c > > @@ -2,7 +2,7 @@ > > * max77693.c - mfd core driver for the MAX 77693 > > * > > * Copyright (C) 2012 Samsung Electronics > > - * SangYoung Son > > + * SangYoung Son > > * > > That's good change. Do you wan't to simply fold the typo fix into your patch? I don't need to carry a trivial change like that as a separate patch, nor does it warrant a "Reported-by" or anything like that. Paul. -- > > As for the rest, I think the driver can be switch to module. Consumer > (phy-samsung-usb2) support deferred probing. I can prepare and test a > patch for that. > > Best regards, > Krzysztof > > > * This program is not provided / owned by Maxim Integrated Products. > > * > > @@ -23,7 +23,7 @@ > > * This driver is based on max8997.c > > */ > > > > -#include > > +#include > > #include > > #include > > #include > > @@ -309,28 +309,10 @@ err_i2c_haptic: > > return ret; > > } > > > > -static int max77693_i2c_remove(struct i2c_client *i2c) > > -{ > > - struct max77693_dev *max77693 = i2c_get_clientdata(i2c); > > - > > - mfd_remove_devices(max77693->dev); > > - > > - regmap_del_irq_chip(max77693->irq, max77693->irq_data_muic); > > - regmap_del_irq_chip(max77693->irq, max77693->irq_data_chg); > > - regmap_del_irq_chip(max77693->irq, max77693->irq_data_topsys); > > - regmap_del_irq_chip(max77693->irq, max77693->irq_data_led); > > - > > - i2c_unregister_device(max77693->i2c_muic); > > - i2c_unregister_device(max77693->i2c_haptic); > > - > > - return 0; > > -} > > - > > static const struct i2c_device_id max77693_i2c_id[] = { > > { "max77693", TYPE_MAX77693 }, > > { } > > }; > > -MODULE_DEVICE_TABLE(i2c, max77693_i2c_id); > > > > static int max77693_suspend(struct device *dev) > > { > > @@ -374,10 +356,10 @@ static struct i2c_driver max77693_i2c_driver = { > > .driver = { > > .name = "max77693", > > .pm = &max77693_pm, > > + .suppress_bind_attrs = true, > > .of_match_table = of_match_ptr(max77693_dt_match), > > }, > > .probe = max77693_i2c_probe, > > - .remove = max77693_i2c_remove, > > .id_table = max77693_i2c_id, > > }; > > > > @@ -387,13 +369,3 @@ static int __init max77693_i2c_init(void) > > } > > /* init early so consumer devices can complete system boot */ > > subsys_initcall(max77693_i2c_init); > > - > > -static void __exit max77693_i2c_exit(void) > > -{ > > - i2c_del_driver(&max77693_i2c_driver); > > -} > > -module_exit(max77693_i2c_exit); > > - > > -MODULE_DESCRIPTION("MAXIM 77693 multi-function core driver"); > > -MODULE_AUTHOR("SangYoung, Son "); > > -MODULE_LICENSE("GPL"); > > >