From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932503AbcDDREH (ORCPT ); Mon, 4 Apr 2016 13:04:07 -0400 Received: from mga01.intel.com ([192.55.52.88]:55659 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932104AbcDDRED (ORCPT ); Mon, 4 Apr 2016 13:04:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,441,1455004800"; d="scan'208";a="680636234" Date: Mon, 4 Apr 2016 10:03:38 -0700 From: Vinod Koul To: Andy Shevchenko Cc: Viresh Kumar , linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Rob Herring , Hans-Christian Egtvedt , Tejun Heo , Mark Brown , Greg Kroah-Hartman , Mark Rutland , Vineet Gupta , stable@vger.kernel.org Subject: Re: [PATCH v3 01/15] dmaengine: dw: fix master selection Message-ID: <20160404170337.GC3515@vkoul-mobl.iind.intel.com> References: <1458311094-94927-1-git-send-email-andriy.shevchenko@linux.intel.com> <1458311094-94927-2-git-send-email-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458311094-94927-2-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 18, 2016 at 04:24:40PM +0200, Andy Shevchenko wrote: > + /* > + * We need controller-specific data to set up slave transfers. > + */ > + BUG_ON(chan->private && !dw_dma_filter(chan, chan->private)); I don't think BUG_ON is apt here, gracefully failing and printing that can be better.. -- ~Vinod