From: Al Viro <viro@ZenIV.linux.org.uk>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jens Axboe <axboe@fb.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [RFC] weird semantics of SG_DXFER_TO_FROM_DEV in BLK_DEV_SKD (drivers/block/skd*)
Date: Mon, 4 Apr 2016 19:47:36 +0100 [thread overview]
Message-ID: <20160404184736.GG17997@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20160404171611.GF17997@ZenIV.linux.org.uk>
On Mon, Apr 04, 2016 at 06:16:12PM +0100, Al Viro wrote:
> will see NULL map_data; the ->from_user case is sg_start_req() stuff. IOW,
> SG_IO behaviour for /dev/sg* is different from the generic one...
While we are at it: in bio_map_user_iov() we have
iov_for_each(iov, i, *iter) {
unsigned long uaddr = (unsigned long) iov.iov_base;
unsigned long len = iov.iov_len;
unsigned long end = (uaddr + len + PAGE_SIZE - 1) >> PAGE_SHIFT;
unsigned long start = uaddr >> PAGE_SHIFT;
/*
* Overflow, abort
*/
if (end < start)
return ERR_PTR(-EINVAL);
nr_pages += end - start;
/*
* buffer must be aligned to at least hardsector size for now
*/
if (uaddr & queue_dma_alignment(q))
return ERR_PTR(-EINVAL);
}
Do we only care about the iov_base alignment? IOW, shouldn't we check for
iov_len being a multiple of queue_dma_alignment(q) as well?
next prev parent reply other threads:[~2016-04-04 18:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 3:38 [RFC] weird semantics of SG_DXFER_TO_FROM_DEV in BLK_DEV_SKD (drivers/block/skd*) Al Viro
2016-04-04 6:52 ` Christoph Hellwig
2016-04-04 17:16 ` Al Viro
2016-04-04 18:47 ` Al Viro [this message]
2016-04-04 19:50 ` Al Viro
2016-04-04 23:45 ` Al Viro
2016-04-07 15:55 ` Christoph Hellwig
2016-04-08 19:19 ` Al Viro
2016-04-07 15:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160404184736.GG17997@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox