The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Lee Jones <lee.jones@linaro.org>,
	Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Laxman Dewangan <ldewangan@nvidia.com>
Subject: Re: [RESEND PATCH] mfd: max77686: Use module_i2c_driver() instead of subsys initcall
Date: Tue, 05 Apr 2016 10:57:01 +0900	[thread overview]
Message-ID: <20160405015701.GA4228@samsunx.samsung> (raw)
In-Reply-To: <1459809962-8883-1-git-send-email-javier@osg.samsung.com>

Hi Javier,

> The driver's init and exit function don't do anything besides adding and
> deleting the I2C driver so the module_i2c_driver() macro could be used.
> 
> Currently is not being used because the driver is initialized at subsys
> initcall level, claiming that this is done to allow consumers devices to
> use the resources provided by this driver. But dependencies are in DT so
> manual ordering of init calls is not necessary any more.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

Reviewed-by: Andi Shyti <andi.shyti@samsung.com>

Thanks,
Andi

  parent reply	other threads:[~2016-04-05  1:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04 22:46 [RESEND PATCH] mfd: max77686: Use module_i2c_driver() instead of subsys initcall Javier Martinez Canillas
2016-04-05  1:47 ` Krzysztof Kozlowski
2016-04-05  1:57 ` Andi Shyti [this message]
2016-04-11 11:51 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160405015701.GA4228@samsunx.samsung \
    --to=andi.shyti@samsung.com \
    --cc=javier@osg.samsung.com \
    --cc=k.kozlowski@samsung.com \
    --cc=ldewangan@nvidia.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox