From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: linux-kernel@vger.kernel.org,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH char-misc-linus] misc: mic: Fix randconfig build error
Date: Tue, 5 Apr 2016 02:03:06 -0400 [thread overview]
Message-ID: <20160405060306.GA2814@kroah.com> (raw)
In-Reply-To: <1459832423.44796.4.camel@localhost>
On Mon, Apr 04, 2016 at 10:00:23PM -0700, Sudeep Dutt wrote:
> On Mon, 2016-04-04 at 21:41 -0700, Greg Kroah-Hartman wrote:
> > On Mon, Apr 04, 2016 at 09:32:30PM -0700, Sudeep Dutt wrote:
> > > Fixes randconfig build error reported at
> > > https://lkml.org/lkml/2016/4/3/135 by ensuring that
> > > the VOP driver selects VIRTIO.
> > >
> > > Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> > > Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > > Signed-off-by: Sudeep Dutt <sudeep.dutt@intel.com>
> > > ---
> > > drivers/misc/mic/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/misc/mic/Kconfig b/drivers/misc/mic/Kconfig
> > > index 2e4f3ba..89e5917 100644
> > > --- a/drivers/misc/mic/Kconfig
> > > +++ b/drivers/misc/mic/Kconfig
> > > @@ -132,6 +132,7 @@ config VOP
> > > tristate "VOP Driver"
> > > depends on 64BIT && PCI && X86 && VOP_BUS
> > > select VHOST_RING
> > > + select VIRTIO
> >
> > Shouldn't it depend on this instead?
>
> Hi Greg,
>
> The documentation for "config VIRTIO" states that "This option is
> selected by any driver which implements the virtio bus". I verified that
> this patch fixes the build for the randconfig which was failing earlier.
Ah, you are right, nevermind, I'll queue this up soon...
thanks,
greg k-h
prev parent reply other threads:[~2016-04-05 6:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 4:32 [PATCH char-misc-linus] misc: mic: Fix randconfig build error Sudeep Dutt
2016-04-05 4:41 ` Greg Kroah-Hartman
2016-04-05 5:00 ` Sudeep Dutt
2016-04-05 6:03 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405060306.GA2814@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ashutosh.dixit@intel.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox