From: Joerg Roedel <jroedel@suse.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Yong Wu <yong.wu@mediatek.com>,
Robin Murphy <robin.murphy@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Alex Williamson <alex.williamson@redhat.com>,
Will Deacon <will.deacon@arm.com>,
Magnus Damm <damm+renesas@opensource.se>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] iommu: provide of_xlate pointer unconditionally
Date: Tue, 5 Apr 2016 13:25:36 +0200 [thread overview]
Message-ID: <20160405112536.GB4203@suse.de> (raw)
In-Reply-To: <1458077877-474066-1-git-send-email-arnd@arndb.de>
On Tue, Mar 15, 2016 at 10:37:17PM +0100, Arnd Bergmann wrote:
> iommu drivers that support the standard DT bindings use a of_xlate
> callback pointer, but that is only part of struct iommu_ops when
> CONFIG_OF_IOMMU is enabled, leading to build errors in randconfig
> builds when that is not provided:
>
> drivers/iommu/mtk_iommu.c:497:2: error: unknown field 'of_xlate' specified in initializer
> .of_xlate = mtk_iommu_of_xlate,
> ^
> drivers/iommu/mtk_iommu.c:497:14: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
> .of_xlate = mtk_iommu_of_xlate,
> ^~~~~~~~~~~~~~~~~~
> drivers/iommu/mtk_iommu.c:497:14: note: (near initialization for 'mtk_iommu_ops.domain_get_attr')
>
> We can work around it by adding more #ifdefs in each driver, but
> it seems nicer to just allow setting the pointer even if it is
> unused. This makes the driver code look nicer, and it gives better
> compile-time coverage when test building on other architectures.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 0df4fabe208d ("iommu/mediatek: Add mt8173 IOMMU driver")
Applied to iommu/fixes, thanks Arnd.
prev parent reply other threads:[~2016-04-05 11:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 21:37 [PATCH] iommu: provide of_xlate pointer unconditionally Arnd Bergmann
2016-03-16 10:47 ` Robin Murphy
2016-04-05 11:25 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405112536.GB4203@suse.de \
--to=jroedel@suse.de \
--cc=alex.williamson@redhat.com \
--cc=arnd@arndb.de \
--cc=damm+renesas@opensource.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robin.murphy@arm.com \
--cc=will.deacon@arm.com \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox