public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Joerg Roedel <joro@8bytes.org>,
	iommu@lists.linux-foundation.org
Subject: Re: [PATCH] intel-iommu: fix up comment
Date: Tue, 5 Apr 2016 11:38:27 +0300	[thread overview]
Message-ID: <20160405113819-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1458757421-4058-1-git-send-email-mst@redhat.com>

On Wed, Mar 23, 2016 at 08:34:19PM +0200, Michael S. Tsirkin wrote:
> dma_pte_free_pagetable no longer depends on
> last level ptes being clear, it clears them itself.
> Fix up the comment to match.
> 
> Cc: Jiang Liu <jiang.liu@linux.intel.com>
> Suggested-by: Alex Williamson <alex.williamson@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Anyone?

> ---
>  drivers/iommu/intel-iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
> index a2e1b7f..0100553 100644
> --- a/drivers/iommu/intel-iommu.c
> +++ b/drivers/iommu/intel-iommu.c
> @@ -1143,7 +1143,7 @@ next:
>  	} while (!first_pte_in_page(++pte) && pfn <= last_pfn);
>  }
>  
> -/* free page table pages. last level pte should already be cleared */
> +/* clear last level (leaf) ptes and free page table pages. */
>  static void dma_pte_free_pagetable(struct dmar_domain *domain,
>  				   unsigned long start_pfn,
>  				   unsigned long last_pfn)
> -- 
> MST

  reply	other threads:[~2016-04-05  8:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-23 18:34 [PATCH] intel-iommu: fix up comment Michael S. Tsirkin
2016-04-05  8:38 ` Michael S. Tsirkin [this message]
2016-04-05 15:01 ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160405113819-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jiang.liu@linux.intel.com \
    --cc=joro@8bytes.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox