public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Ross Zwisler <ross.zwisler@linux.intel.com>
Subject: Re: [PATCH v2] parport: register driver later
Date: Tue, 5 Apr 2016 09:42:06 -0400	[thread overview]
Message-ID: <20160405134206.GA31313@kroah.com> (raw)
In-Reply-To: <5703BAF0.2080506@gmail.com>

On Tue, Apr 05, 2016 at 06:47:36PM +0530, Sudip Mukherjee wrote:
> On Tuesday 05 April 2016 06:28 PM, Greg KH wrote:
> > On Tue, Apr 05, 2016 at 06:26:08AM +0100, Sudip Mukherjee wrote:
> > > On Mon, Mar 07, 2016 at 10:32:55AM -0700, Ross Zwisler wrote:
> > > > On Sun, Mar 06, 2016 at 08:40:10PM +0530, Sudip Mukherjee wrote:
> > > > > If the parport bus is not yet registered and any device using parallel
> > > > > port tries to register with the bus we get a stackdump with a message
> > > > > of Kernel bug.
> > > > > 
> > > > > Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> > > > > Cc: <stable@vger.kernel.org> # 4.2+
> > > > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> > > > > ---
> > > > > 
> > > > > Hi Ross,
> > > > > Can you please test this patch in your setup. This is a respin of the
> > > > > previous patch in another way.
> > > > 
> > > > Yep, this also solves the issue for me.
> > > > 
> > > > Tested-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> > > 
> > > Hi Greg,
> > > If this patch is ok, can we please have it in v4.6 .
> > > Anyway, the problem patch which this patch tried to fix has already
> > > been reverted by Linus -
> > > 1701f680407c ("Revert "ppdev: use new parport device model"") but we still
> > > can have problem with the other devices that use parport.
> > > 
> > > BTW, I know you are busy, but in these situations where I need to have
> > > the fix urgently in the tree, is there any other way to solve the purpose?
> > > I feel it was incompetency on my part where Linus had to interfere and
> > > revert a patch even though the fix was already posted.
> > 
> > A bit better commit message here would have caused me to notice it.
> > Something like "Revert a broken patch because it crashes all of our
> > machines without it!!!" would be a hint it needed to go in :)
> 
> Well. its actually my fault. Previously I used to ping and remind you if
> there is something urgent which needed to go in before your tree closes. But
> this time I got busy with the job change and traveling and everything was a
> mess on my side.
> So, now that the ppdev patch has been reverted by Linus, what do you suggest
> that we do? I will say, to have this patch as a temporary fix (for other
> devices) while I work on the deferred probe for parport which will solve the
> problem.

Work on deferred probe, you should have time before the 4.7-rc1 merge
window happens.

thanks,

greg k-h

  reply	other threads:[~2016-04-05 13:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-06 15:10 [PATCH v2] parport: register driver later Sudip Mukherjee
2016-03-07 17:32 ` Ross Zwisler
2016-04-05  5:26   ` Sudip Mukherjee
2016-04-05 12:58     ` Greg KH
2016-04-05 13:17       ` Sudip Mukherjee
2016-04-05 13:42         ` Greg KH [this message]
2016-04-05 13:44       ` Linus Torvalds
2016-04-05 13:47         ` Greg KH
2016-04-05 14:07           ` Linus Torvalds
     [not found] ` <CA+55aFz0A07bbfSiCuBo4PPnEje1--zPSLuNzYrxqhj0gZFaWA@mail.gmail.com>
2016-04-05 11:54   ` Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160405134206.GA31313@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ross.zwisler@linux.intel.com \
    --cc=stable@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox