From: Joerg Roedel <joro@8bytes.org>
To: cn_wyl2003@126.com
Cc: will.deacon@arm.com, alex.williamson@redhat.com,
renesas@opensource.se, yalin.wang2010@gmail.com,
nicolas.iooss_linux@m4x.org, robin.murphy@arm.com,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu: change generic_device_group function
Date: Tue, 5 Apr 2016 17:04:08 +0200 [thread overview]
Message-ID: <20160405150408.GF11519@8bytes.org> (raw)
In-Reply-To: <1458907611-19694-1-git-send-email-cn_wyl2003@126.com>
On Fri, Mar 25, 2016 at 08:06:51PM +0800, cn_wyl2003@126.com wrote:
> From: yalin wang <yalin.wang2010@gmail.com>
>
> change this function to return only iommu_group* pointer or
> PTR_ERR(), never return NULL when failed.
> The caller of this function only check IS_ERR() for its return value.
>
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
You are right, thanks for catching this. But please leave the
generic_device_group function in iommu.c. It is assigned to a function
pointer by drivers, so inlining it doesn't make sense anyway.
Joerg
prev parent reply other threads:[~2016-04-05 15:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 12:06 [PATCH] iommu: change generic_device_group function cn_wyl2003
2016-04-05 15:04 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160405150408.GF11519@8bytes.org \
--to=joro@8bytes.org \
--cc=alex.williamson@redhat.com \
--cc=cn_wyl2003@126.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.iooss_linux@m4x.org \
--cc=renesas@opensource.se \
--cc=robin.murphy@arm.com \
--cc=will.deacon@arm.com \
--cc=yalin.wang2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox