public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Steve Grubb <sgrubb@redhat.com>
Cc: linux-audit@redhat.com, Oliver Neukum <oneukum@suse.com>,
	Wade Mealing <wmealing@redhat.com>,
	linux-usb <linux-usb@vger.kernel.org>,
	linux-kernel@vger.kernel.org, bjorn@mork.no
Subject: Re: [RFC] Create an audit record of USB specific details
Date: Tue, 5 Apr 2016 18:18:05 -0400	[thread overview]
Message-ID: <20160405221805.GB11038@kroah.com> (raw)
In-Reply-To: <2074584.b2h7oKljRp@x2>

On Tue, Apr 05, 2016 at 03:38:34PM -0400, Steve Grubb wrote:
> On Tuesday, April 05, 2016 07:02:48 PM Oliver Neukum wrote:
> > On Tue, 2016-04-05 at 18:40 +1000, Wade Mealing wrote:
> > > Consider the following scenario.  Currently we have device drivers
> > > that emit text via a printk request which is eventually picked up by
> > > syslog like implementation (not the audit subsystem).
> > 
> > We also have UEVENTs. The crucial question is why udevd feeding
> > back events to the audit subsystem is inferior to the kernel
> > itself generating audit events.
> 
> If this was going to be done in user space, then we are talking about auditd 
> growing the ability to monitor another netlink socket for events. The question 
> that decides if this is feasible is whether or not UEVENTS are protected from 
> loss if several occur in a short time before auditd can get around to reading 
> them.

udevd should queue up your events that you subscribe to just fine.  Test
it out if you want to, it should be pretty easy.

> The other issue that I'm curious about is if adding hardware can fail.

Sure it can, plug in a "broken" USB device and watch it not enumerate
properly :)

> Do the events coming out by UEVENTS have any sense of pass or fail? Or
> are they all implicitly successful?

They only happen when a device is successfully added to the kernel.

> And then we get to the issue of whether or not UEVENTS can be filtered. If so, 
> then we will also need to add auditing around the configuration of the filters 
> to see if anything is impacting the audit trail.

You can filter in userspace, that's what udevd provides for you today.

thanks,

greg k-h

  reply	other threads:[~2016-04-05 22:18 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-04  4:02 [RFC] Create an audit record of USB specific details wmealing
2016-04-04  6:48 ` Oliver Neukum
2016-04-04  7:47   ` Bjørn Mork
2016-04-05  8:40     ` Wade Mealing
2016-04-05 11:49       ` EXT :Re: " Boyce, Kevin P (AS)
2016-04-05 13:46         ` Greg KH
2016-04-05 13:52           ` Boyce, Kevin P (AS)
2016-04-05 15:35             ` Greg KH
2016-04-05 14:40       ` Alan Stern
2016-04-05 22:17         ` Wade Mealing
2016-04-05 17:02       ` Oliver Neukum
2016-04-05 19:38         ` Steve Grubb
2016-04-05 22:18           ` Greg KH [this message]
2016-04-04 12:56 ` Greg KH
2016-04-04 21:33   ` Steve Grubb
2016-04-04 21:48     ` Greg KH
2016-04-04 21:53       ` Greg KH
2016-04-05 13:07         ` Burn Alting
2016-04-05 13:44           ` Greg KH
2016-04-05 14:08             ` Burn Alting
2016-04-05 14:20               ` EXT :Re: " Boyce, Kevin P (AS)
2016-04-05 14:37                 ` Burn Alting
2016-04-05 14:42                   ` Boyce, Kevin P (AS)
2016-04-05 22:39                     ` Burn Alting
2016-04-04 21:37   ` Paul Moore
2016-04-04 21:50     ` Greg KH
2016-04-05  2:54       ` Paul Moore
2016-04-05  3:39         ` Greg KH
2016-04-05 14:50           ` Paul Moore
2016-04-04 21:37 ` Steve Grubb
2016-04-04 21:54   ` Greg KH
     [not found]     ` <CALJHwhR-SA7K=fD=DUXE7EFq+4gWKPaY+B5z6jdCj7180wg_vg@mail.gmail.com>
2016-04-05  1:54       ` Wade Mealing
2016-04-05  2:43         ` Greg KH
2016-04-05  2:47         ` Greg KH
2016-04-04 22:10   ` Burn Alting

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160405221805.GB11038@kroah.com \
    --to=greg@kroah.com \
    --cc=bjorn@mork.no \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=sgrubb@redhat.com \
    --cc=wmealing@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox