From: Kent Overstreet <kent.overstreet@gmail.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Jens Axboe <axboe@fb.com>,
linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Boaz Harrosh <boaz@plexistor.com>, Jan Kara <jack@suse.cz>,
Keith Busch <keith.busch@intel.com>, Tejun Heo <tj@kernel.org>,
Mike Snitzer <snitzer@redhat.com>
Subject: Re: [PATCH 01/27] block: bio: introduce 4 helpers for cleanup
Date: Tue, 5 Apr 2016 16:18:41 -0800 [thread overview]
Message-ID: <20160406001841.GA31161@kmo-pixel> (raw)
In-Reply-To: <1459857443-20611-2-git-send-email-tom.leiming@gmail.com>
On Tue, Apr 05, 2016 at 07:56:46PM +0800, Ming Lei wrote:
> Some drivers access bio->bi_vcnt and bio->bi_io_vec directly,
> firstly it isn't a good practice, secondly it may cause trouble
> for converting to multipage bvecs.
"not good practice" is OO bullshit snake oil without more justification. We
don't plaster accessors everywhere without an actual reason.
How would it cause trouble with multipage bvecs?
next prev parent reply other threads:[~2016-04-06 0:18 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 11:56 [PATCH 00/27] block: cleanup direct access on .bi_vcnt & .bi_io_vec Ming Lei
2016-04-05 11:56 ` [PATCH 01/27] block: bio: introduce 4 helpers for cleanup Ming Lei
2016-04-06 0:18 ` Kent Overstreet [this message]
2016-04-06 1:34 ` Ming Lei
2016-04-06 1:46 ` Kent Overstreet
2016-04-06 2:11 ` Ming Lei
2016-04-06 2:21 ` Kent Overstreet
2016-04-06 4:11 ` Ming Lei
2016-04-05 11:56 ` [PATCH 02/27] block: drbd: use bio_get_base_vec() to retrieve the 1st bvec Ming Lei
2016-04-05 11:56 ` [PATCH 03/27] block: drbd: remove impossible failure handling Ming Lei
2016-04-05 12:42 ` Lars Ellenberg
2016-04-05 11:56 ` [PATCH 04/27] block: loop: use bio_get_base_vec() to retrive bvec table Ming Lei
2016-04-05 11:56 ` [PATCH 05/27] block: pktcdvd: " Ming Lei
2016-04-05 11:56 ` [PATCH 06/27] block: floppy: use bio_set_vec_table() Ming Lei
2016-04-05 13:00 ` Christoph Hellwig
2016-04-05 11:56 ` [PATCH 07/27] block: floppy: use bio_add_page() Ming Lei
2016-04-05 11:56 ` [PATCH 08/27] staging: lustre: avoid to use bio->bi_vcnt directly Ming Lei
2016-04-05 12:59 ` Greg Kroah-Hartman
2016-04-05 13:01 ` Christoph Hellwig
2016-04-10 14:37 ` James Simmons
2016-04-10 14:41 ` Christoph Hellwig
2016-04-10 16:02 ` James Simmons
2016-04-11 3:30 ` Ming Lei
2016-04-05 11:56 ` [PATCH 09/27] target: use bio_is_full() Ming Lei
2016-04-05 13:02 ` Christoph Hellwig
2016-04-07 4:07 ` Ming Lei
2016-04-05 11:56 ` [PATCH 10/27] bcache: debug: avoid to access .bi_io_vec directly Ming Lei
2016-04-05 11:56 ` [PATCH 11/27] bcache: io.c: use bio_set_vec_table Ming Lei
2016-04-05 12:49 ` Christoph Hellwig
2016-04-05 15:24 ` Ming Lei
2016-04-05 17:31 ` Christoph Hellwig
2016-04-06 0:35 ` Kent Overstreet
2016-04-05 11:56 ` [PATCH 12/27] bcache: journal.c: use bio_set_vec_table() Ming Lei
2016-04-05 11:56 ` [PATCH 13/27] bcache: movinggc: " Ming Lei
2016-04-05 11:56 ` [PATCH 14/27] bcache: writeback: " Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160406001841.GA31161@kmo-pixel \
--to=kent.overstreet@gmail.com \
--cc=axboe@fb.com \
--cc=boaz@plexistor.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=tj@kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox