From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760768AbcDFFeK (ORCPT ); Wed, 6 Apr 2016 01:34:10 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34452 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754167AbcDFFeI (ORCPT ); Wed, 6 Apr 2016 01:34:08 -0400 Date: Wed, 6 Apr 2016 14:33:26 +0900 From: Sergey Senozhatsky To: Rui Salvaterra Cc: Greg KH , linux-kernel@vger.kernel.org, eunb.song@samsung.com, minchan@kernel.org, linux-mm@kvack.org, Sergey Senozhatsky , Sergey Senozhatsky Subject: Re: [BUG] lib: zram lz4 compression/decompression still broken on big endian Message-ID: <20160406053325.GA415@swordfish> References: <20160405153439.GA2647@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (04/05/16 17:02), Rui Salvaterra wrote: [..] > > For some reason it never got merged, sorry, I don't remember why. > > > > Have you tested this patch? If so, can you resend it with your > > tested-by: line added to it? > > > > thanks, > > > > greg k-h > > Hi, Greg > > > No, I haven't tested the patch at all. I want to do so, and fix if if > necessary, but I still need to learn how to (meaning, I need to watch > your "first kernel patch" presentation again). I'd love to get > involved in kernel development, and this seems to be a good > opportunity, if none of the kernel gods beat me to it (I may need a > month, but then again nobody complained about this bug in almost two > years). Hello Rui, may we please ask you to test the patch first? quite possible there is nothing to fix there; I've no access to mips h/w but the patch seems correct to me. LZ4_READ_LITTLEENDIAN_16 does get_unaligned_le16(), so LZ4_WRITE_LITTLEENDIAN_16 must do put_unaligned_le16() /* not put_unaligned() */ -ss