From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760396AbcDFHt5 (ORCPT ); Wed, 6 Apr 2016 03:49:57 -0400 Received: from mail-pf0-f169.google.com ([209.85.192.169]:36449 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754676AbcDFHtz (ORCPT ); Wed, 6 Apr 2016 03:49:55 -0400 Date: Wed, 6 Apr 2016 15:43:10 +0800 From: Peter Chen To: Felipe Balbi Cc: Baolin Wang , gregkh@linuxfoundation.org, sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org, peter.chen@freescale.com, stern@rowland.harvard.edu, r.baldyga@samsung.com, yoshihiro.shimoda.uh@renesas.com, lee.jones@linaro.org, broonie@kernel.org, ckeepax@opensource.wolfsonmicro.com, patches@opensource.wolfsonmicro.com, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, device-mainlining@lists.linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 1/4] gadget: Introduce the usb charger framework Message-ID: <20160406074310.GC21101@shlinux2.ap.freescale.net> References: <6c594cc66fd06b575b04cc8bb0fe0374d0501d4d.1459494744.git.baolin.wang@linaro.org> <20160406072513.GB21101@shlinux2.ap.freescale.net> <87vb3v2nm8.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87vb3v2nm8.fsf@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 06, 2016 at 10:38:23AM +0300, Felipe Balbi wrote: > Peter Chen writes: > > On Fri, Apr 01, 2016 at 03:21:49PM +0800, Baolin Wang wrote: > > + > >> +static struct attribute *usb_charger_attrs[] = { > >> + &dev_attr_sdp_current.attr, > >> + &dev_attr_dcp_current.attr, > >> + &dev_attr_cdp_current.attr, > >> + &dev_attr_aca_current.attr, > >> + &dev_attr_charger_type.attr, > >> + &dev_attr_charger_state.attr, > >> + NULL > >> +}; > > > > The user may only care about current limit, type and state, why they > > need to care what type's current limit, it is the usb charger > > framework handles, the framework judge the current according to > > charger type and USB state (connect/configured/suspended). > > it might be useful if we want to know that $this charger doesn't really > give us as much current as it advertises. > As my understanding, the current limit is dynamic value, it should report the value the charger supports now, eg, it connects SDP, but the host is suspended now, then the value should be 2mA. -- Best Regards, Peter Chen