From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755252AbcDFMc7 (ORCPT ); Wed, 6 Apr 2016 08:32:59 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:49587 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754864AbcDFMc6 (ORCPT ); Wed, 6 Apr 2016 08:32:58 -0400 Date: Wed, 6 Apr 2016 15:32:49 +0300 From: Dan Carpenter To: Nicholas Sim Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rts5208: ensure braces on all arms of if stmt Message-ID: <20160406123249.GA5451@mwanda> References: <20160405162917.GA19711@cog.davos> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160405162917.GA19711@cog.davos> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 05, 2016 at 05:29:17PM +0100, Nicholas Sim wrote: > Added braces on if arm of if statement where else arm already needs braces > as suggested for clarity in Documentation/CodingStyle > > Signed-off-by: Nicholas Sim > --- > drivers/staging/rts5208/ms.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c > index 3e75db7..2ad4ea0 100644 > --- a/drivers/staging/rts5208/ms.c > +++ b/drivers/staging/rts5208/ms.c > @@ -794,8 +794,9 @@ static int ms_confirm_cpu_startup(struct rtsx_chip *chip) > } > > if (val & INT_REG_ERR) { > - if (val & INT_REG_CMDNK) > + if (val & INT_REG_CMDNK) { > chip->card_wp |= (MS_CARD); > + } > else { It should be } else { on one line. regards, dan carpenter http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel