From: "Radim Krčmář" <rkrcmar@redhat.com>
To: rhett rhett <rhett.kernel@gmail.com>
Cc: linux-kernel@vger.kernel.org, gleb@kernel.org, kvm@vger.kernel.org
Subject: Re: [patch] remove unnecessary code in hyperv.c
Date: Wed, 6 Apr 2016 14:39:26 +0200 [thread overview]
Message-ID: <20160406123925.GG21537@potion.brq.redhat.com> (raw)
In-Reply-To: <CABvbLL3SBVbqpuahWgrFcBR22dDfT0CSvNLX20379yL3V+osKw@mail.gmail.com>
2016-04-06 10:21+0800, rhett rhett:
> 8499907b52c9cebf3c1a4aaa63b84bd9c3c1ff3d
> arch/x86/kvm/hyperv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c
> index 01bd7b7..e831032 100644
> --- a/arch/x86/kvm/hyperv.c
> +++ b/arch/x86/kvm/hyperv.c
> @@ -807,7 +807,6 @@ static int kvm_hv_set_msr_pw(struct kvm_vcpu *vcpu, u32
> msr, u64 data,
> gfn << HV_X64_MSR_TSC_REFERENCE_ADDRESS_SHIFT,
> &tsc_ref, sizeof(tsc_ref)))
> return 1;
> - mark_page_dirty(kvm, gfn);
> break;
> }
> case HV_X64_MSR_CRASH_P0 ... HV_X64_MSR_CRASH_P4:
>
>
> i think the mark_page_dirty is unnecessary, because the page had been mark
> as dirty inside the
> kvm_write_guest routinue.
Yes, good catch.
> so , can this patch be accepted ?
An acceptable patch needs to follow Documentation/SubmittingPatches,
would you like to make the submission?
parent reply other threads:[~2016-04-06 12:39 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CABvbLL3SBVbqpuahWgrFcBR22dDfT0CSvNLX20379yL3V+osKw@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160406123925.GG21537@potion.brq.redhat.com \
--to=rkrcmar@redhat.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rhett.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox