From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751785AbcDFPBS (ORCPT ); Wed, 6 Apr 2016 11:01:18 -0400 Received: from mail-pf0-f174.google.com ([209.85.192.174]:35418 "EHLO mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897AbcDFPBQ (ORCPT ); Wed, 6 Apr 2016 11:01:16 -0400 Date: Wed, 6 Apr 2016 20:31:12 +0530 From: Viresh Kumar To: Doug Smythies Cc: "'Srinivas Pandruvada'" , "'Joe Perches'" , "'Len Brown'" , "'Rafael J. Wysocki'" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] intel_pstate: Use pr_fmt Message-ID: <20160406150112.GC16889@vireshk-i7> References: <710e23a9e0846d1aaa660849321e433b5f5dd4e7.1459887986.git.joe@perches.com> <1459892619.7030.2.camel@linux.intel.com> <002601d19013$c129de60$437d9b20$@net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <002601d19013$c129de60$437d9b20$@net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06-04-16, 07:51, Doug Smythies wrote: > On 2016.04.05 02:44 Srinivas Pandruvada wrote: > > On Tue, 2016-04-05 at 13:28 -0700, Joe Perches wrote: > >> Prefix the output using the more common kernel style. > >> > >> Signed-off-by: Joe Perches > > Acked-by: Srinivas Pandruvada > >> --- > >> drivers/cpufreq/intel_pstate.c | 18 ++++++++++-------- > >> 1 file changed, 10 insertions(+), 8 deletions(-) > > ...[cut, example left]... > > > - pr_warn("intel_pstate: Turbo disabled by BIOS or > > unavailable on processor\n"); > > + pr_warn("Turbo disabled by BIOS or unavailable on > > processor\n"); > > I do not understand. > The common and unique string "intel_pstate" was added on purpose > so as to provide a way to easily extract the related message from > an otherwise huge log file. The first line of the patch does this: +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt which will automagically add name of the current file (intel_pstate) before every print message printed using pr_*() helpers. -- viresh