Re: [PATCH] KERNEL: resource: Fix bug on leakage in /proc/iomem file

Kees Cook
2016-04-06T21:27:44Z

On Wed, Apr 6, 2016 at 2:19 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Wed, Apr 6, 2016 at 10:54 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> So I'd find a patch like the attached to be perfectly acceptable (in
>> fact, we should have done this long ago).
>
> I just committed it, let's see if some odd program uses the iomem
> data. I doubt it, and I always enjoy improvements that remove more
> lines of code than they add.

Hrm, okay. I still think just changing the perms would be less
troublesome. Knowing where the kernel is in physical memory when
debugging physical memory issues seems important to me. But, I have
never actually used it since I prefer looking in kallsyms. :)

-Kees

--
Kees Cook
Chrome OS & Brillo Security