From: Mark Brown <broonie@kernel.org>
To: Martin Fuzzey <mfuzzey@parkeon.com>
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: Regulator: drivers that need to know their supply
Date: Thu, 7 Apr 2016 10:02:49 -0700 [thread overview]
Message-ID: <20160407170249.GV1924@sirena.org.uk> (raw)
In-Reply-To: <57065FB5.6040707@parkeon.com>
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
On Thu, Apr 07, 2016 at 03:25:09PM +0200, Martin Fuzzey wrote:
> To implement the .enable_time() method I need the voltage (which is
> the supply's voltage).
No, this is not sensible. You should be telling the framework about the
slew rate and letting the framework work out how long it's going to take
to transition. Your driver shouldn't be peering around inside other
regulators, it should be telling the framework what it does itself and
any handling of interrelationships should be in the framework.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-04-07 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 13:25 Regulator: drivers that need to know their supply Martin Fuzzey
2016-04-07 17:02 ` Mark Brown [this message]
2016-04-07 18:17 ` Martin Fuzzey
2016-04-10 23:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407170249.GV1924@sirena.org.uk \
--to=broonie@kernel.org \
--cc=javier@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfuzzey@parkeon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox