From: Chris Bainbridge <chris.bainbridge@gmail.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: gregkh@linuxfoundation.org, johan@kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
stern@rowland.harvard.edu
Subject: Re: [PATCH] usb: core: hub: hub_port_init lock controller instead of bus
Date: Thu, 7 Apr 2016 18:40:28 +0100 [thread overview]
Message-ID: <20160407174028.GA14673@localhost> (raw)
In-Reply-To: <56BB6FC2.8090804@linux.intel.com>
On Wed, Feb 10, 2016 at 07:13:38PM +0200, Mathias Nyman wrote:
>
> Most likely xhci is messed up after two device slots are in default state at the same time.
> This happens when both threads are in hub_port_init() have called hub_port_reset()
>
> The issue becomes visible when the the descriptor read and set address both fail after
> the port resets.
>
> xhci specs 4.5.3 has one tiny note about this:
> "Note: Software shall not transition more than one Device Slot to the Default State at a time"
>
> So to me, and from xhci pov this patch looks like the correct solution,
> but I might be missing some usb core side details.
>
> -Mathias
>
Just following up to see if this patch disappeared into the void?
prev parent reply other threads:[~2016-04-07 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 13:49 [PATCH] usb: core: hub: hub_port_init lock controller instead of bus Chris Bainbridge
2016-02-10 17:13 ` Mathias Nyman
2016-04-07 17:40 ` Chris Bainbridge [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407174028.GA14673@localhost \
--to=chris.bainbridge@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).