From: Andy Gross <andy.gross@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Sreedhar Sambangi <ssambang@codeaurora.org>,
mark.rutland@arm.com, devicetree@vger.kernel.org,
linux@arm.linux.org.uk, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
qca-upstream.external@qca.qualcomm.com, david.brown@linaro.org,
galak@codeaurora.org, linux-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] qcom: ipq4019: Add regulator support to DK04 device tree
Date: Thu, 7 Apr 2016 13:11:22 -0500 [thread overview]
Message-ID: <20160407181122.GA18396@hector.attlocal.net> (raw)
In-Reply-To: <20160407175736.GI32257@rob-hp-laptop>
On Thu, Apr 07, 2016 at 12:57:36PM -0500, Rob Herring wrote:
> On Mon, Apr 04, 2016 at 02:08:10PM -0700, Sreedhar Sambangi wrote:
> > This adds the regulator nodes to DK04 device tree to support
> >
> > Change-Id: I9c1df0e720a330bf6db1889fd2247f6a70ea6faa
> > Signed-off-by: Sreedhar Sambangi <ssambang@codeaurora.org>
> > ---
> > .../bindings/regulator/ipq4019-regulator.txt | 19 +++++++++++++++++++
> > arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi | 11 +++++++++++
> > 2 files changed, 30 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/regulator/ipq4019-regulator.txt
> >
> > diff --git a/Documentation/devicetree/bindings/regulator/ipq4019-regulator.txt b/Documentation/devicetree/bindings/regulator/ipq4019-regulator.txt
> > new file mode 100644
> > index 0000000..9d934a4
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/regulator/ipq4019-regulator.txt
> > @@ -0,0 +1,19 @@
> > +* Qualcomm Technologies, Inc. IPQ4019 regulators
> > +
> > +Required properties:
> > +- compatible : Must be "regulator-ipq4019".
>
> Doesn't match your example which correctly has vendor prefix. Also, the
> preferred form is <vendor>,<soc>-<block>.
>
> > +- states : Selection of available voltages and corresponding values
>
> Too generic of a name.
>
> Is this not fixed by the h/w block?
I'd put this info in the driver itself. I believe it has 4 fixed states.
>
> > +- reg : Register address for controlling LDO
> > +- mask : Mask value for switching voltages
>
> What else is in this register? If something unrelated, then this is all
> wrong to the regulator. You can only define the register address in one
> place in the DT. Otherwise, you should know the mask from the compatible
> string.
I agree. All of this needs to be done inside the code itself. All you need is
the register. This is a TCSR register which means that it could have other bits
doing other things. I would hope that the hw guys isolated only regulator bits
in here.
Regards,
Andy Gross
prev parent reply other threads:[~2016-04-07 18:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 21:08 [PATCH 1/2] qcom: ipq4019: Add regulator support to DK04 device tree Sreedhar Sambangi
2016-04-05 5:59 ` Andy Gross
2016-04-06 4:55 ` Sreedhar Sambangi
2016-04-07 17:57 ` Rob Herring
2016-04-07 18:11 ` Andy Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407181122.GA18396@hector.attlocal.net \
--to=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=qca-upstream.external@qca.qualcomm.com \
--cc=robh@kernel.org \
--cc=ssambang@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox