public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-kernel@vger.kernel.org, Wang Nan <wangnan0@huawei.com>,
	Jiri Olsa <jolsa@kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH] scripts: Fallback to KBUILD_OUTPUT if O is not specified
Date: Fri, 8 Apr 2016 11:58:47 -0300	[thread overview]
Message-ID: <20160408145847.GE5327@redhat.com> (raw)
In-Reply-To: <1460106849-6435-1-git-send-email-thierry.reding@gmail.com>

Em Fri, Apr 08, 2016 at 11:14:09AM +0200, Thierry Reding escreveu:
> From: Thierry Reding <treding@nvidia.com>
> 
> The KBUILD_OUTPUT environment can be used to set the build directory as
> an alternative to passing the O variable on the command-line. This works
> with regular kernel builds, so it's surprising if it doesn't work within
> the tools/scripts directory.
> 
> Allow KBUILD_OUTPUT if O is not specified on the command-line to avoid
> any surprises.

I think this is fine, Jiri, Wang?

- Arnaldo
 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> Hi Arnaldo,
> 
> I'm not sure if you're the right person to send this to. There was noone
> reported by scripts/get_maintainer.pl, but it looks like you ended up
> applying most of the patches to this file lately, which kinda makes you
> the de facto maintainer =).
> 
> Thierry
> 
>  tools/scripts/Makefile.include | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/scripts/Makefile.include b/tools/scripts/Makefile.include
> index 8abbef164b4e..5467da41dc72 100644
> --- a/tools/scripts/Makefile.include
> +++ b/tools/scripts/Makefile.include
> @@ -8,6 +8,10 @@ ifeq ($(objtree),)
>  	objtree := $(O)
>  endif
>  endif
> +else
> +ifneq ($(KBUILD_OUTPUT),)
> +	OUTPUT := $(KBUILD_OUTPUT)/$(if $(subdir),$(subdir)/)
> +endif
>  endif
>  
>  # check that the output directory actually exists
> -- 
> 2.8.0

  reply	other threads:[~2016-04-08 14:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08  9:14 [PATCH] scripts: Fallback to KBUILD_OUTPUT if O is not specified Thierry Reding
2016-04-08 14:58 ` Arnaldo Carvalho de Melo [this message]
2016-04-08 15:37   ` Wangnan (F)
2016-04-08 15:48     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160408145847.GE5327@redhat.com \
    --to=acme@redhat.com \
    --cc=acme@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox