From: Leon Romanovsky <leon@leon.nu>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Faisal Latif <faisal.latif@intel.com>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/infiniband/hw/nes/nes_verbs.c: Deinline nes_free_qp_mem, save 1072 bytes
Date: Mon, 11 Apr 2016 07:41:48 +0300 [thread overview]
Message-ID: <20160411044148.GE20252@leon.nu> (raw)
In-Reply-To: <1460141926-13069-1-git-send-email-dvlasenk@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
On Fri, Apr 08, 2016 at 08:58:42PM +0200, Denys Vlasenko wrote:
> This function compiles to 550 bytes of machine code.
> Three callsites, all in nes_create_qp.
I agree with you, the functions which calls below and after this
function are not optimized for speed and there is no need to inline
this function.
I have two requests from you.
1)
Can you please change title to be more convenient?
[PATCH] drivers/infiniband/hw/nes/nes_verbs.c: Deinline nes_free_qp_mem, save 1072 bytes
--->
[PATCH] IB/nes: Deinline nes_free_qp_mem
2) Add bloat-o-meter output to the commit message.
And after that feel free to add my RB tag.
Reviewed-By: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-04-11 4:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 18:58 [PATCH] drivers/infiniband/hw/nes/nes_verbs.c: Deinline nes_free_qp_mem, save 1072 bytes Denys Vlasenko
2016-04-08 18:58 ` [PATCH] drivers/scsi/fnic/fnic_scsi.c: Deinline fnic_queue_abort_io_req, save 1792 bytes Denys Vlasenko
2016-04-08 19:08 ` Laurence Oberman
2016-04-12 2:16 ` Martin K. Petersen
2016-04-08 18:58 ` [PATCH] drivers/virtio/virtio_ring.c: Deinline virtqueue_add, save 1016 bytes Denys Vlasenko
2016-04-09 20:14 ` Michael S. Tsirkin
2016-04-08 18:58 ` [PATCH] fs/gfs2/glock.c: Deinline do_error, save 1856 bytes Denys Vlasenko
2016-04-08 19:17 ` Bob Peterson
2016-04-08 19:46 ` Denys Vlasenko
2016-04-12 16:49 ` Bob Peterson
2016-04-08 18:58 ` [PATCH] lockdep: Deinline register_lock_class, save 2328 bytes Denys Vlasenko
2016-04-13 11:28 ` [tip:locking/core] locking/lockdep: Deinline register_lock_class(), " tip-bot for Denys Vlasenko
2016-04-11 4:41 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411044148.GE20252@leon.nu \
--to=leon@leon.nu \
--cc=dledford@redhat.com \
--cc=dvlasenk@redhat.com \
--cc=faisal.latif@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox